Skip to content

Commit 4a5ddce

Browse files
committed
addressed some comments
1 parent 82ce53a commit 4a5ddce

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

sdks/python/apache_beam/runners/worker/channel_factory.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,24 +23,12 @@
2323

2424
class GRPCChannelFactory(grpc.StreamStreamClientInterceptor):
2525
DEFAULT_OPTIONS = [
26-
# Default: 30000ms (30s), increased to 180s to reduce ping frequency
27-
("grpc.keepalive_time_ms", 180000),
28-
# Default: 5000ms (5s), increased to 10 minutes for stability
26+
# Default: 20000ms (20s), increased to 10 minutes for stability
2927
("grpc.keepalive_timeout_ms", 600000),
3028
# Default: 2, set to 0 to allow unlimited pings without data
3129
("grpc.http2.max_pings_without_data", 0),
3230
# Default: False, set to True to allow keepalive pings when no calls
3331
("grpc.keepalive_permit_without_calls", True),
34-
# Default: 300000ms (5min), increased to 10min for stability
35-
("grpc.http2.min_recv_ping_interval_without_data_ms", 600000),
36-
# Default: 300000ms (5min), increased to 120s for conservative pings
37-
("grpc.http2.min_sent_ping_interval_without_data_ms", 120000),
38-
# Default: 2, set to 0 to allow unlimited ping strikes
39-
("grpc.http2.max_ping_strikes", 0),
40-
# Default: 0 (disabled), enable socket reuse for better handling
41-
("grpc.so_reuseport", 1),
42-
# Default: 0 (disabled), set 30s TCP timeout for connection control
43-
("grpc.tcp_user_timeout_ms", 30000),
4432
]
4533

4634
def __init__(self):

sdks/python/apache_beam/utils/subprocess_server.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,6 @@ def start(self):
188188
channel_options = [
189189
("grpc.max_receive_message_length", -1),
190190
("grpc.max_send_message_length", -1),
191-
# Default: 30000ms (30s), increased to 180s to reduce ping frequency
192-
("grpc.keepalive_time_ms", 180000),
193191
# Default: 5000ms (5s), increased to 10 minutes for stability
194192
("grpc.keepalive_timeout_ms", 600000),
195193
# Default: 2, set to 0 to allow unlimited pings without data
@@ -204,8 +202,6 @@ def start(self):
204202
("grpc.http2.max_ping_strikes", 0),
205203
# Default: 0 (disabled), enable socket reuse for better handling
206204
("grpc.so_reuseport", 1),
207-
# Default: 0 (disabled), set 30s TCP timeout for connection control
208-
("grpc.tcp_user_timeout_ms", 30000),
209205
]
210206
self._grpc_channel = grpc.insecure_channel(
211207
endpoint, options=channel_options)

0 commit comments

Comments
 (0)