Skip to content

Commit 5df9628

Browse files
sdks/python: replace the deprecated testcontainer max tries
1 parent 7457694 commit 5df9628

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

sdks/python/apache_beam/ml/rag/enrichment/milvus_search_it_test.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
MilvusClient,
5454
RRFRanker)
5555
from pymilvus.milvus_client import IndexParams
56-
from testcontainers.core.config import MAX_TRIES as TC_MAX_TRIES
5756
from testcontainers.core.config import testcontainers_config
5857
from testcontainers.core.generic import DbContainer
5958
from testcontainers.milvus import MilvusContainer
@@ -306,13 +305,15 @@ def start_db_container(
306305
image="milvusdb/milvus:v2.5.10",
307306
max_vec_fields=5,
308307
vector_client_max_retries=3,
309-
tc_max_retries=TC_MAX_TRIES) -> Optional[MilvusDBContainerInfo]:
308+
tc_max_retries=None) -> Optional[MilvusDBContainerInfo]:
310309
service_container_port = MilvusEnrichmentTestHelper.find_free_port()
311310
healthcheck_container_port = MilvusEnrichmentTestHelper.find_free_port()
312311
user_yaml_creator = MilvusEnrichmentTestHelper.create_user_yaml
313312
with user_yaml_creator(service_container_port, max_vec_fields) as cfg:
314313
info = None
315-
testcontainers_config.max_tries = tc_max_retries
314+
original_tc_max_tries = testcontainers_config.max_tries
315+
if not testcontainers_config.max_tries:
316+
testcontainers_config.max_tries = tc_max_retries
316317
for i in range(vector_client_max_retries):
317318
try:
318319
vector_db_container = CustomMilvusContainer(
@@ -325,7 +326,7 @@ def start_db_container(
325326
host = vector_db_container.get_container_host_ip()
326327
port = vector_db_container.get_exposed_port(service_container_port)
327328
info = MilvusDBContainerInfo(vector_db_container, host, port)
328-
testcontainers_config.max_tries = TC_MAX_TRIES
329+
testcontainers_config.max_tries = original_tc_max_tries
329330
_LOGGER.info(
330331
"milvus db container started successfully on %s.", info.uri)
331332
break

0 commit comments

Comments
 (0)