test refactor.

Author: claudevdm

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java

@@ -115,6 +115,8 @@ public class BigQueryUtils {
               + "(?<DATASET>[a-zA-Z0-9_]{1,1024})[\\.]"
               + "(?<TABLE>[\\p{L}\\p{M}\\p{N}\\p{Pc}\\p{Pd}\\p{Zs}$]{1,1024})$");
 
+  private static final long PICOSECOND_PRECISION = 12L;
+
   /** Options for how to convert BigQuery data to Beam data. */
   @AutoValue
   public abstract static class ConversionOptions implements Serializable {
@@ -416,7 +418,7 @@ public static TimestampPicos parseTimestampPicosFromString(String timestampStrin
         String fractionalPart =
             timestampString.substring(dotIndex + 1, timestampString.length() - 1);
 
-        if (fractionalPart.length() == 12) {
+        if ((long) fractionalPart.length() == PICOSECOND_PRECISION) {
           // ISO timestamp with 12 decimal digits (picosecond precision)
           // Parse the datetime part (without fractional seconds)
           String dateTimePart = timestampString.substring(0, dotIndex) + "Z";

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java

@@ -216,6 +216,8 @@ public interface ThrowingBiFunction<FirstInputT, SecondInputT, OutputT> {
   static final DecimalFormat DECIMAL_FORMAT =
       new DecimalFormat("0.0###############", DecimalFormatSymbols.getInstance(Locale.ROOT));
 
+  private static final long PICOSECOND_PRECISION = 12L;
+
   // Map of functions to convert json values into the value expected in the Vortex proto object.
   static final Map<TableFieldSchema.Type, ThrowingBiFunction<String, Object, @Nullable Object>>
       TYPE_MAP_PROTO_CONVERTERS =
@@ -982,7 +984,7 @@ static TableFieldSchema tableFieldSchemaFromDescriptorField(FieldDescriptor fiel
       case MESSAGE:
         if (fieldDescriptor.getMessageType().getName().equals("TimestampPicos")) {
           tableFieldSchemaBuilder.setType(TableFieldSchema.Type.TIMESTAMP);
-          tableFieldSchemaBuilder.setPrecision(12);
+          tableFieldSchemaBuilder.setPrecision(PICOSECOND_PRECISION);
         } else {
           tableFieldSchemaBuilder = tableFieldSchemaBuilder.setType(TableFieldSchema.Type.STRUCT);
           TableSchema nestedTableField =
@@ -1090,7 +1092,7 @@ private static void fieldDescriptorFromTableField(
             fieldDescriptorBuilder.setType(Type.TYPE_MESSAGE).setTypeName(nested.getName());
         break;
       case TIMESTAMP:
-        if (fieldSchema.getTimestampPrecision().getValue() == 12) {
+        if (fieldSchema.getTimestampPrecision().getValue() == PICOSECOND_PRECISION) {
           boolean typeAlreadyExists =
               descriptorBuilder.getNestedTypeList().stream()
                   .anyMatch(d -> TIMESTAMP_PICOS_DESCRIPTOR_PROTO.getName().equals(d.getName()));
@@ -1362,7 +1364,7 @@ public static ByteString mergeNewFields(
                 null);
       }
     } else if (schemaInformation.getType() == TableFieldSchema.Type.TIMESTAMP
-        && schemaInformation.getTimestampPrecision() == 12) {
+        && schemaInformation.getTimestampPrecision() == PICOSECOND_PRECISION) {
 
       long seconds;
       long picoseconds;