Skip to content

Commit 8668509

Browse files
authored
Use singleton prism server by default. (#36228)
* Use singleton prism server by default. * Modify test since we make prism singleton the default.
1 parent 6b6af8d commit 8668509

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

sdks/python/apache_beam/runners/portability/prism_runner.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ def default_job_server(self, options):
7575
debug_options = options.view_as(pipeline_options.DebugOptions)
7676
get_job_server = lambda: job_server.StopOnExitJobServer(
7777
PrismJobServer(options))
78-
if debug_options.lookup_experiment("enable_prism_server_singleton"):
79-
return PrismRunner.shared_handle.acquire(get_job_server)
80-
return get_job_server()
78+
if debug_options.lookup_experiment("disable_prism_server_singleton"):
79+
return get_job_server()
80+
return PrismRunner.shared_handle.acquire(get_job_server)
8181

8282
def create_job_service_handle(self, job_service, options):
8383
return portable_runner.JobServiceHandle(

sdks/python/apache_beam/runners/portability/prism_runner_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,9 @@ class PrismRunnerSingletonTest(unittest.TestCase):
461461
@parameterized.expand([True, False])
462462
def test_singleton(self, enable_singleton):
463463
if enable_singleton:
464-
options = DebugOptions(["--experiment=enable_prism_server_singleton"])
464+
options = DebugOptions() # prism singleton is enabled by default
465465
else:
466-
options = DebugOptions()
466+
options = DebugOptions(["--experiment=disable_prism_server_singleton"])
467467

468468
runner = prism_runner.PrismRunner()
469469
with mock.patch(

0 commit comments

Comments
 (0)