Remove tests wrongly asserting that reiteration is still cached.

Author: robertwb

sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/StateBackedIterableTest.java

@@ -32,7 +32,6 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Random;
-import org.apache.beam.fn.harness.Cache;
 import org.apache.beam.fn.harness.Caches;
 import org.apache.beam.model.fnexecution.v1.BeamFnApi.StateKey;
 import org.apache.beam.sdk.coders.StringUtf8Coder;
@@ -111,75 +110,6 @@ public void testReiteration() throws Exception {
       assertEquals(expected, Lists.newArrayList(iterable));
     }
 
-    @Test
-    public void testReiterationCached() throws Exception {
-      FakeBeamFnStateClient fakeBeamFnStateClient =
-          new FakeBeamFnStateClient(
-              StringUtf8Coder.of(),
-              ImmutableMap.of(
-                  key("nonEmptySuffix"), asList("C", "D", "E", "F", "G", "H", "I", "J", "K"),
-                  key("emptySuffix"), asList()));
-
-      StateBackedIterable<String> iterable =
-          new StateBackedIterable<>(
-              Caches.eternal(),
-              fakeBeamFnStateClient,
-              "instruction",
-              key(suffixKey),
-              StringUtf8Coder.of(),
-              prefix);
-
-      // Ensure that the load is lazy
-      assertEquals(0, fakeBeamFnStateClient.getCallCount());
-      assertEquals(expected, Lists.newArrayList(iterable));
-      // We expect future reiterations to not perform any loads
-      int callCount = fakeBeamFnStateClient.getCallCount();
-      assertEquals(expected, Lists.newArrayList(iterable));
-      assertEquals(expected, Lists.newArrayList(iterable));
-      assertEquals(callCount, fakeBeamFnStateClient.getCallCount());
-    }
-
-    @Test
-    public void testCacheKeyIsUnique() throws Exception {
-      // Share a cache for multiple iterables leads to distinct keys being used.
-      Cache cache = Caches.eternal();
-      FakeBeamFnStateClient fakeBeamFnStateClient =
-          new FakeBeamFnStateClient(
-              StringUtf8Coder.of(),
-              ImmutableMap.of(
-                  key("nonEmptySuffix"), asList("C", "D", "E", "F", "G", "H", "I", "J", "K"),
-                  key("emptySuffix"), asList(),
-                  key("otherIterable"), asList("Z")));
-
-      StateBackedIterable<String> otherIterable =
-          new StateBackedIterable<>(
-              cache,
-              fakeBeamFnStateClient,
-              "instruction",
-              key("otherIterable"),
-              StringUtf8Coder.of(),
-              Collections.emptyList());
-      // Ensure that the load is lazy
-      assertEquals(0, fakeBeamFnStateClient.getCallCount());
-      assertEquals(asList("Z"), Lists.newArrayList(otherIterable));
-
-      StateBackedIterable<String> iterable =
-          new StateBackedIterable<>(
-              cache,
-              fakeBeamFnStateClient,
-              "instruction",
-              key(suffixKey),
-              StringUtf8Coder.of(),
-              prefix);
-
-      assertEquals(expected, Lists.newArrayList(iterable));
-      // We expect future reiterations to not perform any loads
-      int callCount = fakeBeamFnStateClient.getCallCount();
-      assertEquals(expected, Lists.newArrayList(iterable));
-      assertEquals(expected, Lists.newArrayList(iterable));
-      assertEquals(callCount, fakeBeamFnStateClient.getCallCount());
-    }
-
     @Test
     public void testUsingInterleavedReiteration() throws Exception {
       FakeBeamFnStateClient fakeBeamFnStateClient =