Skip to content

Commit 8d400da

Browse files
authored
Merge pull request #34562: [extensions-proto] Return correct TypeDescriptor for ProtoCoder (#34561)
2 parents 9de36d5 + 582a246 commit 8d400da

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoder.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,11 @@ public Class<T> getMessageType() {
237237
return protoMessageClass;
238238
}
239239

240+
@Override
241+
public TypeDescriptor<T> getEncodedTypeDescriptor() {
242+
return TypeDescriptor.of(protoMessageClass);
243+
}
244+
240245
public Set<Class<?>> getExtensionHosts() {
241246
return extensionHostClasses;
242247
}

sdks/java/extensions/protobuf/src/test/java/org/apache/beam/sdk/extensions/protobuf/ProtoCoderTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,12 @@ public void testNonDeterministicProperty() throws CoderException {
169169
assertNotEquals(CoderUtils.encodeToBase64(coder, msg2), CoderUtils.encodeToBase64(coder, msg1));
170170
}
171171

172+
@Test
173+
public void testEncodedTypeDescriptor() {
174+
Coder<MessageA> coder = ProtoCoder.of(MessageA.class);
175+
assertEquals(TypeDescriptor.of(MessageA.class), coder.getEncodedTypeDescriptor());
176+
}
177+
172178
@Test
173179
public void testSerialVersionID() {
174180
long serialVersionID = ObjectStreamClass.lookup(ProtoCoder.class).getSerialVersionUID();

0 commit comments

Comments
 (0)