Skip to content

Commit 8dd03dc

Browse files
authored
Remove leftover logic handling Java8 container (#35988)
1 parent ac00807 commit 8dd03dc

File tree

2 files changed

+3
-35
lines changed

2 files changed

+3
-35
lines changed

sdks/java/container/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ ADD target/beam-sdks-java-harness.jar /opt/apache/beam/jars/
3434
# Required to use jamm as a javaagent to get accurate object size measuring
3535
# COPY fails if file is not found, so use a wildcard for open-module-agent.jar
3636
# since it is only included in Java 9+ containers
37-
COPY target/jamm.jar target/open-module-agent*.jar /opt/apache/beam/jars/
37+
COPY target/jamm.jar target/open-module-agent.jar /opt/apache/beam/jars/
3838

3939
COPY target/${TARGETOS}_${TARGETARCH}/boot /opt/apache/beam/
4040

sdks/java/container/common.gradle

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ task copyDockerfileDependencies(type: Copy) {
5252
rename 'jcl-over-slf4j.*', 'jcl-over-slf4j.jar'
5353
rename 'log4j-over-slf4j.*', 'log4j-over-slf4j.jar'
5454
rename 'log4j-to-slf4j.*', 'log4j-to-slf4j.jar'
55-
if (imageJavaVersion == "11" || imageJavaVersion == "17") {
56-
rename 'beam-sdks-java-container-agent.*.jar', 'open-module-agent.jar'
57-
}
55+
rename 'beam-sdks-java-container-agent.*.jar', 'open-module-agent.jar'
5856
rename 'beam-sdks-java-harness-.*.jar', 'beam-sdks-java-harness.jar'
5957
rename 'jamm.*.jar', 'jamm.jar'
6058

@@ -84,9 +82,7 @@ task copyGolangLicenses(type: Copy) {
8482
}
8583

8684
task copyJdkOptions(type: Copy) {
87-
if (["11", "17", "21"].contains(imageJavaVersion)) {
88-
from "option-jamm.json"
89-
}
85+
from "option-jamm.json"
9086
from "java${imageJavaVersion}-security.properties"
9187
from "option-java${imageJavaVersion}-security.json"
9288
into "build/target/options"
@@ -97,33 +93,6 @@ task skipPullLicenses(type: Exec) {
9793
args "-c", "mkdir -p build/target/go-licenses build/target/options build/target/third_party_licenses && touch build/target/go-licenses/skip && touch build/target/third_party_licenses/skip"
9894
}
9995

100-
// Java11+ container depends on the java agent project. To compile it, need a compatible JDK version:
101-
// lower bound 11 and upper bound imageJavaVersion
102-
task validateJavaHome {
103-
def requiredForVer = ["11", "17", "21"]
104-
if (requiredForVer.contains(imageJavaVersion)) {
105-
doFirst {
106-
if (JavaVersion.VERSION_1_8.compareTo(JavaVersion.current()) < 0) {
107-
return
108-
}
109-
boolean propertyFound = false
110-
// enable to build agent with compatible java versions (11-requiredForVer)
111-
for (def checkVer : requiredForVer) {
112-
if (project.hasProperty("java${checkVer}Home")) {
113-
propertyFound = true
114-
}
115-
if (checkVer == imageJavaVersion) {
116-
// cannot build agent with a higher version than the docker java ver
117-
break
118-
}
119-
}
120-
if (!propertyFound) {
121-
throw new GradleException("System Java needs to have version 11+ or java${imageJavaVersion}Home required for imageJavaVersion=${imageJavaVersion}. Re-run with -Pjava${imageJavaVersion}Home")
122-
}
123-
}
124-
}
125-
}
126-
12796
def pushContainers = project.rootProject.hasProperty(["isRelease"]) || project.rootProject.hasProperty("push-containers")
12897

12998
docker {
@@ -162,4 +131,3 @@ if (project.rootProject.hasProperty("docker-pull-licenses") ||
162131
dockerPrepare.dependsOn copySdkHarnessLauncher
163132
dockerPrepare.dependsOn copyDockerfileDependencies
164133
dockerPrepare.dependsOn copyJdkOptions
165-
dockerPrepare.dependsOn validateJavaHome

0 commit comments

Comments
 (0)