Skip to content

Commit b7448da

Browse files
committed
modify exclusions and trigger validates runner
1 parent 027ddf8 commit b7448da

File tree

3 files changed

+26
-4
lines changed

3 files changed

+26
-4
lines changed

.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
55
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
66
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
7+
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8+
"https://github.com/apache/beam/pull/36631": "dofn lifecycle",
89
}

.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
"https://github.com/apache/beam/pull/31156": "noting that PR #31156 should run this test",
55
"https://github.com/apache/beam/pull/31268": "noting that PR #31268 should run this test",
66
"https://github.com/apache/beam/pull/31490": "noting that PR #31490 should run this test",
7-
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface"
7+
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
8+
"https://github.com/apache/beam/pull/36631": "dofn lifecycle validation",
89
}

runners/google-cloud-dataflow-java/build.gradle

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,17 @@ task validatesRunner {
451451
excludedTests: [
452452
// TODO(https://github.com/apache/beam/issues/21472)
453453
'org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState',
454-
]
454+
455+
// These tests use static state and don't work with remote execution.
456+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInFinishBundle',
457+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInFinishBundleStateful',
458+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement',
459+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElementStateful',
460+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInSetup',
461+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInSetupStateful',
462+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle',
463+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundleStateful',
464+
]
455465
))
456466
}
457467

@@ -473,7 +483,17 @@ task validatesRunnerStreaming {
473483
// GroupIntoBatches.withShardedKey not supported on streaming runner v1
474484
// https://github.com/apache/beam/issues/22592
475485
'org.apache.beam.sdk.transforms.GroupIntoBatchesTest.testWithShardedKeyInGlobalWindow',
476-
]
486+
487+
// These tests use static state and don't work with remote execution.
488+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInFinishBundle',
489+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInFinishBundleStateful',
490+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElement',
491+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElementStateful',
492+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInSetup',
493+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInSetupStateful',
494+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundle',
495+
'org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInStartBundleStateful',
496+
]
477497
))
478498
}
479499

0 commit comments

Comments
 (0)