Move GetExperiments to a common place for other boot.go

Author: shunping

sdks/go/container/tools/pipeline_options.go

@@ -42,3 +42,36 @@ func MakePipelineOptionsFileAndEnvVar(options string) error {
 	os.Setenv("PIPELINE_OPTIONS_FILE", f.Name())
 	return nil
 }
+
+type PipelineOptionsData struct {
+	Options OptionsData `json:"options"`
+}
+
+type OptionsData struct {
+	Experiments []string `json:"experiments"`
+}
+
+// GetExperiments extracts a string array from the options string (in JSON format)
+//
+// The json string of pipeline options is in the following format.
+// We only focus on experiments here.
+//
+//	{
+//		 "display_data": [
+//		  	{...},
+//		 ],
+//		 "options": {
+//		  	...
+//			  "experiments": [
+//				...
+//			 ],
+//		 }
+//	}
+func GetExperiments(options string) []string {
+	var opts PipelineOptionsData
+	err := json.Unmarshal([]byte(options), &opts)
+	if err != nil {
+		return nil
+	}
+	return opts.Options.Experiments
+}

sdks/go/container/tools/pipeline_options_test.go

@@ -56,3 +56,51 @@ func TestMakePipelineOptionsFileAndEnvVar(t *testing.T) {
 	}
 	os.Remove("pipeline_options.json")
 }
+
+func TestGetExperiments(t *testing.T) {
+	tests := []struct {
+		name         string
+		inputOptions string
+		expectedExps []string
+	}{
+		{
+			"no experiments",
+			`{"options": {"a": "b"}}`,
+			nil,
+		},
+		{
+			"valid experiments",
+			`{"options": {"experiments": ["a", "b"]}}`,
+			[]string{"a", "b"},
+		},
+		{
+			"empty experiments",
+			`{"options": {"experiments": []}}`,
+			[]string{},
+		},
+		{
+			"invalid json",
+			`{options: {"experiments": []}}`,
+			nil,
+		},
+		{
+			"empty string",
+			"",
+			nil,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			exps := GetExperiments(test.inputOptions)
+			if len(exps) != len(test.expectedExps) {
+				t.Errorf("got: %v, want: %v", exps, test.expectedExps)
+			}
+			for i, v := range exps {
+				if v != test.expectedExps[i] {
+					t.Errorf("got: %v, want: %v", exps, test.expectedExps)
+				}
+			}
+		})
+	}
+}

sdks/python/container/boot.go

@@ -117,37 +117,6 @@ func main() {
 	}
 }
 
-// The json string of pipeline options is in the following format.
-// We only focus on experiments here.
-//
-//	{
-//		 "display_data": [
-//		  	{...},
-//		 ],
-//		 "options": {
-//		  	...
-//			  "experiments": [
-//				...
-//			 ],
-//		 }
-//	}
-type PipelineOptionsData struct {
-	Options OptionsData `json:"options"`
-}
-
-type OptionsData struct {
-	Experiments []string `json:"experiments"`
-}
-
-func getExperiments(options string) []string {
-	var opts PipelineOptionsData
-	err := json.Unmarshal([]byte(options), &opts)
-	if err != nil {
-		return nil
-	}
-	return opts.Options.Experiments
-}
-
 func launchSDKProcess() error {
 	ctx := grpcx.WriteWorkerID(context.Background(), *id)
 
@@ -187,7 +156,7 @@ func launchSDKProcess() error {
 		logger.Fatalf(ctx, "Failed to convert pipeline options: %v", err)
 	}
 
-	experiments := getExperiments(options)
+	experiments := tools.GetExperiments(options)
 	pipNoBuildIsolation = false
 	if slices.Contains(experiments, "pip_no_build_isolation") {
 		pipNoBuildIsolation = true