Skip to content

Commit def0678

Browse files
authored
Clean up Typescript Tests workflow (#33458)
* Remove reference to static GCP credentials * Conditionally run xlang tests * Make Dataflow tests conditional
1 parent 5944a30 commit def0678

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

.github/workflows/typescript_tests.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ name: TypeScript Tests
2121

2222
on:
2323
workflow_dispatch:
24+
inputs:
25+
runXlang:
26+
description: 'Type "true" if you want to run xlang tests'
27+
default: false
28+
runDataflow:
29+
description: 'Type "true" if you want to run Dataflow tests'
30+
default: false
2431
schedule:
2532
- cron: '10 2 * * *'
2633
push:
@@ -68,6 +75,8 @@ jobs:
6875
# if: ${{ matrix.os != 'ubuntu-latest' }}
6976
typescript_xlang_tests:
7077
name: 'TypeScript xlang Tests'
78+
# TODO(https://github.com/apache/beam/issues/33346): remove manual trigger after fixing referenced issue.
79+
if: (github.event_name == 'workflow_dispatch' && github.event.inputs.runXlang == 'true')
7180
runs-on: [self-hosted, ubuntu-20.04]
7281
timeout-minutes: 15
7382
strategy:
@@ -115,16 +124,16 @@ jobs:
115124
GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
116125
GCP_REGION: ${{ secrets.GCP_REGION }}
117126
GCP_SA_EMAIL: ${{ secrets.GCP_SA_EMAIL }}
118-
GCP_SA_KEY: ${{ secrets.GCP_SA_KEY }}
119127
GCP_TESTING_BUCKET: ${{ secrets.GCP_TESTING_BUCKET }}
120128
GCP_PYTHON_WHEELS_BUCKET: "not-needed-here"
121129

122130
typescript_dataflow_tests:
123131
name: 'TypeScript Dataflow Tests'
132+
# TODO(https://github.com/apache/beam/issues/33346): remove manual trigger after fixing referenced issue.
133+
if: (github.event_name == 'workflow_dispatch' && github.event.inputs.runDataflow == 'true')
124134
runs-on: ubuntu-latest
125135
needs:
126136
- check_gcp_variables
127-
if: needs.check_gcp_variables.outputs.gcp-variables-set == 'true'
128137
strategy:
129138
fail-fast: false
130139
steps:
@@ -146,11 +155,6 @@ jobs:
146155
run: |
147156
pip install 'pandas>=1.0,<1.5'
148157
pip install -e ".[gcp]"
149-
- name: Authenticate on GCP
150-
uses: google-github-actions/auth@v1
151-
with:
152-
credentials_json: ${{ secrets.GCP_SA_KEY }}
153-
project_id: ${{ secrets.GCP_PROJECT_ID }}
154158
- run: npm ci
155159
working-directory: ./sdks/typescript
156160
- run: npm run build

0 commit comments

Comments
 (0)