Fix flaky AsyncBatchWriteHandlerTest.correctlyLimitConcurrency (#36975)

scwhittle · web-flow · commit e24a2a2eeb96 · 2025-12-03T18:27:17.000-05:00
diff --git a/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java b/sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java
@@ -230,7 +230,7 @@ public void correctlyLimitConcurrency() throws Throwable {
     nextResults.complete(emptyList());
 
     handler.waitForCompletion();
-    assertThat(future).isDone();
+    eventually(5, () -> assertThat(future).isDone());
   }
 
   static class SubmitFn<T, V> implements BiFunction<String, List<T>, CompletableFuture<List<V>>> {

Original file line number	Diff line number	Diff line change
`@@ -230,7 +230,7 @@ public void correctlyLimitConcurrency() throws Throwable {`
`230`	`230`	`nextResults.complete(emptyList());`
`231`	`231`
`232`	`232`	`handler.waitForCompletion();`
`233`		`- assertThat(future).isDone();`
	`233`	`+ eventually(5, () -> assertThat(future).isDone());`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`static class SubmitFn<T, V> implements BiFunction<String, List<T>, CompletableFuture<List<V>>> {`