Revert "Report delta StringSet counters for streaming"#33821
Closed
Revert "Report delta StringSet counters for streaming"#33821
Conversation
This reverts commit bbe6394.
Contributor
Author
liferoad
approved these changes
Jan 31, 2025
Contributor
Contributor
Author
|
testConsumedWorkItems_itemsSplitAcrossResponses (org.apache.beam.runners.dataflow.worker.windmill.client.grpc.GrpcDirectGetWorkStreamTest) failed due to #28957, not related to this change |
Contributor
|
Can we submit this instead (ran the test locally it passes)? |
Contributor
Author
|
superceded by #33823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #33691
Let's revert on master branch and forward fix at the same time, to keep PreCommit Java green