Skip to content

Adding handling of Nulled lists to beam_row_from_dict#33830

Merged
ahmedabu98 merged 2 commits intoapache:masterfrom
TobiasBredow:handle_null_repeated
Feb 3, 2025
Merged

Adding handling of Nulled lists to beam_row_from_dict#33830
ahmedabu98 merged 2 commits intoapache:masterfrom
TobiasBredow:handle_null_repeated

Conversation

@TobiasBredow
Copy link
Copy Markdown
Contributor

Addresses #32155 and fixes the handling of missing repeated fields inside a dicts when converting a dict to a beam row. As described in the issue it matches BigQuery standard behaviour of converting Null repeated fields to empty arrays on insert.
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#array_nulls


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@TobiasBredow
Copy link
Copy Markdown
Contributor Author

Run Python_Dataframes PreCommit 3.12

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Copy Markdown
Contributor

will defer to @ahmedabu98 who authored this code.

Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this change! Just had one suggestion

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
@TobiasBredow
Copy link
Copy Markdown
Contributor Author

@ahmedabu98 Added the change you suggested, thanks for that makes it cleaner.

Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding to the repo @TobiasBredow :)

LGTM, will merge when tests pass

@ahmedabu98 ahmedabu98 merged commit c7b2695 into apache:master Feb 3, 2025
tomstepp pushed a commit to tomstepp/apache-beam that referenced this pull request Feb 3, 2025
* Adding handling of Nulled lists to beam_row_from_dict

* Update sdks/python/apache_beam/io/gcp/bigquery_tools.py

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>

---------

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
* Adding handling of Nulled lists to beam_row_from_dict

* Update sdks/python/apache_beam/io/gcp/bigquery_tools.py

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>

---------

Co-authored-by: Ahmed Abualsaud <65791736+ahmedabu98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants