[Java] Ensure Pipeline Execution Requires Configuration Options or Logs Warning#34220
[Java] Ensure Pipeline Execution Requires Configuration Options or Logs Warning#34220Suvrat1629 wants to merge 2 commits intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@kennknowles Gentle ping! Could you please take a look and provide comments to improve this pr. |
|
Reminder, please take a look at this pr: @kennknowles |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Reminder, please take a look at this pr: @kennknowles |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
| public static Pipeline create() { | ||
| Pipeline pipeline = new Pipeline(PipelineOptionsFactory.create()); | ||
| PipelineOptions options = PipelineOptionsFactory.create(); | ||
| if (options.getRunner() == null) { |
There was a problem hiding this comment.
We don't want this. The runner is intentionally not something the pipeline should know about while it is being created.
There was a problem hiding this comment.
(we actually did a lot of work to remove the runner a while back :-)
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Reminder, please take a look at this pr: @kennknowles |
|
waiting on author |
|
Hi @Suvrat1629 is this still in progress? |
|
waiting on author |
4 participants
Please add a meaningful description for your change here
This change ensures that running a Pipeline without specifying configuration options is either prevented with an error or flagged with a prominent warning.
Closes #18699
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.