[Bug]: typo in docs - Python Composition with AfterWatermark example

[mataralhawiti]

What happened?

I was reading through the Triggers examples, and I feel there's a typo in https://beam.apache.org/documentation/programming-guide/#composite-afterwatermark

Here's the example description from docs:

You can express this pattern using AfterWatermark. For example, the following example trigger code fires on the following conditions:

On Beam’s estimate that all the data has arrived (the watermark passes the end of the window)

Any time late data arrives, after a ten-minute delay

After two days, we assume no more data of interest will arrive, and the trigger stops executing

pcollection | WindowInto(
    FixedWindows(1 * 60),
    trigger=AfterWatermark(late=AfterProcessingTime(10 * 60)),

    
    allowed_lateness=10, ###--> I think it should be allowed_lateness=2
    accumulation_mode=AccumulationMode.DISCARDING)

Issue Priority

Priority: 3 (minor)

Issue Components

• Component: Python SDK
• Component: Java SDK
• Component: Go SDK
• Component: Typescript SDK
• Component: IO connector
• Component: Beam YAML
• Component: Beam examples
• Component: Beam playground
• Component: Beam katas
• Component: Website
• Component: Infrastructure
• Component: Spark Runner
• Component: Flink Runner
• Component: Samza Runner
• Component: Twister2 Runner
• Component: Hazelcast Jet Runner
• Component: Google Cloud Dataflow Runner

[Brijeshthummar02]

@mataralhawiti assign me i can fix it.

[liferoad]

For Python, allowed_lateness – Maximum delay in seconds after end of window allowed for any late data to be processed without being discarded directly. So the doc should be allowed_lateness=2*24*60*60.

[mataralhawiti]

thanks @liferoad for the update, that's what I thought.

[mataralhawiti]

@mataralhawiti assign me i can fix it.

please see @liferoad update for the correct format.

[Brijeshthummar02]

@mataralhawiti than should it be updated? If so, to what.

[mataralhawiti]

@mataralhawiti than should it be updated? If so, to what.
@Brijeshthummar02 it should be :

allowed_lateness=2*24*60*60

[Brijeshthummar02]

It means allowed_lateness=1,72,800

[mataralhawiti]

@Brijeshthummar02 yeah which is 2 days, but for consistency and following formatting style we use 2*24*60*60, please feel free to update your PR with the correct value.

[Brijeshthummar02]

@mataralhawiti i have made the appropriate changes, please have a look.