Skip to content

Add Drain mode to PaneInfo#34530

Closed
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:drain_mode
Closed

Add Drain mode to PaneInfo#34530
kennknowles wants to merge 1 commit intoapache:masterfrom
kennknowles:drain_mode

Conversation

@kennknowles
Copy link
Member

This is not yet instantiated by any runner, so will always be the default value, and never included in encoded PaneInfo since default values do not result in extended metadata being added.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Apr 3, 2025

/** {@link DrainMode} indicates whether a pipeline is known to be draining or not. */
public enum DrainMode {
UNSPECIFIED,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I have gotten this far into implementation, I can see that the SDK does not need this value. It is necessary in protobuf but should be converted to NOT_DRAINING because we want to never encode it unless it is draining.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@kennknowles
Copy link
Member Author

Closing this in favor of new suggestion by @stankiewicz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant