Skip to content

Fix PostCommit Python Dependency and PreCommit Python ML tests#34559

Merged
damccorm merged 1 commit intoapache:masterfrom
akvelon:fix-python-dependency-and-ml-tests
Apr 7, 2025
Merged

Fix PostCommit Python Dependency and PreCommit Python ML tests#34559
damccorm merged 1 commit intoapache:masterfrom
akvelon:fix-python-dependency-and-ml-tests

Conversation

@akashorabek
Copy link
Copy Markdown
Collaborator

@akashorabek akashorabek commented Apr 7, 2025

Fixes: #31285, #30799
Successful PostCommit Python Dependency example: https://github.com/akashorabek/beam/actions/runs/14305849321
Successful PreCommit Python ML tests with ML deps installed example: https://github.com/akashorabek/beam/actions/runs/14305842322

Explicitly installed latest accelerate for tests that require the latest version of transformers (4.51.0), since otherwise it throws the error: "NameError: name 'init_empty_weights' is not defined". The solution is described here. Also switched from encode to tokenize in langchain_test.py.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Apr 7, 2025
for chunk in chunks:
# Verify each chunk's token length is within limits
num_tokens = len(tokenizer.encode(chunk.content.text))
num_tokens = len(tokenizer.tokenize(chunk.content.text))
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, this is a known issue where the encode function adds 2 extra tokens. Replaced it with tokenize since it solved the problem here.

@akashorabek akashorabek marked this pull request as ready for review April 7, 2025 12:47
@akashorabek akashorabek requested a review from damccorm April 7, 2025 12:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Amar3tto
Copy link
Copy Markdown
Collaborator

Amar3tto commented Apr 7, 2025

Run Prism_Python PreCommit 3.12

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit aba093d into apache:master Apr 7, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Python ML tests with ML deps installed job is flaky

3 participants