Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @chamikaramj for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Let's try not to disable ITs to fix flakes and let's try to fix the test instead. Unless this is submit blocking which I don't think is the case. |
akashorabek
changed the title
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
| } | ||
|
|
||
| @Override | ||
| public Catalog createCatalog() { |
There was a problem hiding this comment.
since createCatalog is called in setup() which is a non-static method, salt should also be non-static member
| Timeout.seconds(OPTIONS.getRunner().equals(DirectRunner.class) ? 300 : 20 * 60); | ||
|
|
||
| private static final int NUM_SHARDS = 10; | ||
| private static final int NUM_SHARDS = 1; |
There was a problem hiding this comment.
Will this remove test coverage of sharded case? We can decrease shard / number of records on direct runner but good to keep parallelism on other runners (Dataflow)
cc: @ahmedabu98
|
I don't think that failing tests are related to the changes in this PR |
|
Let me reopen the pr to re-trigger tests |
@Abacn Thanks. These 2 failures are not related to the pr changes. |
3 participants
Fixes: #31931
Successul run example: https://github.com/akashorabek/beam/actions/runs/14610522701
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.