Skip to content

Add Git commit SHA to artifacts using buildnumber-maven-plugin (#18227)#34833

Closed
gayatrikate04 wants to merge 1 commit intoapache:masterfrom
gayatrikate04:add-commit-sha
Closed

Add Git commit SHA to artifacts using buildnumber-maven-plugin (#18227)#34833
gayatrikate04 wants to merge 1 commit intoapache:masterfrom
gayatrikate04:add-commit-sha

Conversation

@gayatrikate04
Copy link
Copy Markdown
Contributor

This pull request introduces the buildnumber-maven-plugin to the Apache Beam project to include the Git commit SHA in the MANIFEST.MF file of the generated artifacts. This update helps in identifying the commit associated with each build and ensures traceability.

The changes are made to the pom.xml file, where the plugin is configured to retrieve the Git commit SHA and include it in the artifact’s metadata.

This PR solves issue #18227 by adding a mechanism to automatically attach the Git commit SHA to the built artifact.

@github-actions github-actions bot added the java label May 4, 2025
@liferoad liferoad requested a review from Abacn May 4, 2025 14:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 4, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @chamikaramj

@github-actions
Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @kennknowles

@github-actions
Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2025

Reminder, please take a look at this pr: @robertwb

@kennknowles
Copy link
Copy Markdown
Member

I don't know this well enough to know if there is any risk. @Abacn do you know?

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Jun 6, 2025

There is some misunderstanding here. maven-archetype is shipped as source codes, used as template project. When user work on such project, there is no assumption they will use git or want this traceability on their own project. I think we should close this.

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Copy Markdown
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Copy Markdown
Contributor

Reminder, please take a look at this pr: @chamikaramj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants