Add Git commit SHA to artifacts using buildnumber-maven-plugin (#18227)#34833
Add Git commit SHA to artifacts using buildnumber-maven-plugin (#18227)#34833gayatrikate04 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @chamikaramj for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
|
|
Reminder, please take a look at this pr: @kennknowles |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb |
|
I don't know this well enough to know if there is any risk. @Abacn do you know? |
|
There is some misunderstanding here. maven-archetype is shipped as source codes, used as template project. When user work on such project, there is no assumption they will use git or want this traceability on their own project. I think we should close this. |
|
Reminder, please take a look at this pr: @robertwb |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @chamikaramj for label java. Available commands:
|
|
Reminder, please take a look at this pr: @chamikaramj |
This pull request introduces the
buildnumber-maven-pluginto the Apache Beam project to include the Git commit SHA in theMANIFEST.MFfile of the generated artifacts. This update helps in identifying the commit associated with each build and ensures traceability.The changes are made to the
pom.xmlfile, where the plugin is configured to retrieve the Git commit SHA and include it in the artifact’s metadata.This PR solves issue #18227 by adding a mechanism to automatically attach the Git commit SHA to the built artifact.