Fix PostCommit Java Examples Dataflow V2 workflow#35015
Conversation
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} | ||
| GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }} | ||
| GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }} | ||
| DOCKER_TAG: latest |
There was a problem hiding this comment.
Is this "latest" tag needed? Below it sets DOCKER_TAG to a unique tag, overrides this default. And checked us.gcr.io/apache-beam-testing/github-actions/beam_java17_sdk_distroless no image has tagged "latest"
There was a problem hiding this comment.
Thanks for catching that, I’ve removed the line.
|
I had another look at this build file yesterday and it seemed to me like there's some duplicate and outdated bits and pieces that I started to clean up in #34999. I haven't had time to come back to it with a blank mind, but feel free to cherry-pick from that PR if those changes make any sense. |
|
Thanks @sjvanrossum ! Let me merge this at the moment to bring back test green. Take your time on #34999. |
* Fix PostCommit Java Examples Dataflow V2 workflow * Remove unnecessary DOCKER_TAG declaration
Fixes: #33646
Successful run example: https://github.com/akashorabek/beam/actions/runs/15141978605
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.