Skip to content

Fix PostCommit Java Examples Dataflow V2 workflow#35015

Merged
Abacn merged 2 commits intoapache:masterfrom
akvelon:fix-#33646
May 21, 2025
Merged

Fix PostCommit Java Examples Dataflow V2 workflow#35015
Abacn merged 2 commits intoapache:masterfrom
akvelon:fix-#33646

Conversation

@akashorabek
Copy link
Collaborator

@akashorabek akashorabek commented May 20, 2025

Fixes: #33646
Successful run example: https://github.com/akashorabek/beam/actions/runs/15141978605


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
DOCKER_TAG: latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "latest" tag needed? Below it sets DOCKER_TAG to a unique tag, overrides this default. And checked us.gcr.io/apache-beam-testing/github-actions/beam_java17_sdk_distroless no image has tagged "latest"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, I’ve removed the line.

@sjvanrossum
Copy link
Contributor

I had another look at this build file yesterday and it seemed to me like there's some duplicate and outdated bits and pieces that I started to clean up in #34999. I haven't had time to come back to it with a blank mind, but feel free to cherry-pick from that PR if those changes make any sense.

@Abacn
Copy link
Contributor

Abacn commented May 21, 2025

Thanks @sjvanrossum ! Let me merge this at the moment to bring back test green. Take your time on #34999.

@Abacn Abacn merged commit dbcb710 into apache:master May 21, 2025
19 checks passed
changliiu pushed a commit to changliiu/beam that referenced this pull request May 22, 2025
* Fix PostCommit Java Examples Dataflow V2 workflow

* Remove unnecessary DOCKER_TAG declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java Examples Dataflow V2 job is flaky

3 participants