Skip to content

fix prism runner race condition#35024

Merged
lostluck merged 1 commit intoapache:masterfrom
tosolveit:fix-go-prism-runner-data-race
May 30, 2025
Merged

fix prism runner race condition#35024
lostluck merged 1 commit intoapache:masterfrom
tosolveit:fix-go-prism-runner-data-race

Conversation

@tosolveit
Copy link
Contributor

Fixes #34316

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tosolveit
Copy link
Contributor Author

tosolveit commented May 22, 2025

Hi, this workflow needs approval because it runs on pull_request_target and comes from a fork. Could someone with write access approve it so the CI can complete?

assign set of reviewers

Copy link
Collaborator

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it will be great to get @lostluck final opinion on this.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! Thank you for the fix! There are probably a few more places where the lock could be changed to a RLock instead, but those can be in other CLs.

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @lostluck for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck lostluck merged commit 697e054 into apache:master May 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Go Prism Runner has a Data Race in v2.63.0

3 participants