fixed encoding_positions_set

[liferoad]

fixes #35318

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[github-actions]

Assigning reviewers:

R: @claudevdm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[damccorm]

I think this is a Dataflow issue and should be addressed at that level. It looks like we're not correctly setting this on pipeline update in all cases.

[liferoad]

I think this is a Dataflow issue and should be addressed at that level. It looks like we're not correctly setting this on pipeline update in all cases.

Will my PR mitigate this issue or it does not matter since it will be override by Dataflow?

[liferoad]

@jonathaningram possible to help me test this PR?

[damccorm]

I think this is a Dataflow issue and should be addressed at that level. It looks like we're not correctly setting this on pipeline update in all cases.

Will my PR mitigate this issue or it does not matter since it will be override by Dataflow?

It will probably mitigate this issue, but (a) there is probably a general bug which is being introduced by Dataflow here, and (b) this feature is meant to provide safety guarantees when we update which we are losing.

[liferoad]

Let us close this PR for now. Please create the GCP support ticket to investigate this.

[raletty]

Hey @liferoad, we are currently running into this issue. Would it be possible if you could provide the link to your support ticket if it's public so that we can track its resolution?

[liferoad]

@raletty it is not public. but @acrites from the Dataflow team can reproduce this now and have the fix, which should be rolled out later.