Adding GCP Spanner Change Stream support for Python#35453
Adding GCP Spanner Change Stream support for Python#35453damccorm merged 7 commits intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
|
|
Reminder, please take a look at this pr: @jrmccluskey @kennknowles @nielm |
|
@nielm could you please take a look at this one? |
|
Reminder, please take a look at this pr: @jrmccluskey @kennknowles @nielm |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
|
|
R: @nielm |
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Stopping reviewer notifications for this pull request: requested by reviewer. If you'd like to restart, comment |
|
Sorry for the delay in getting to this. Can you confirm that you have manually run integration tests on this? |
|
assign set of reviewers |
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
LGTM |
|
assign to next reviewer |
nielm
left a comment
There was a problem hiding this comment.
LGTM
(again in the hope that PR-bot assigns the next reviewer in the chain...)
* Adding Spanner Change Stream support to python. * Updating CHANGES.md * Fixing python format * Modify CHANGES.md * Restarting Tests * Retesting
Fix: Correctly assign feature to release. apache#35453
Fix: Correctly assign feature to release. #35453
Adding GCP Spanner Change Stream support for python (
fixes #24103).This update enables reading from Spanner Change Streams using
apache_beam.io.gcp.spannerby incorporating cross-language transforms from the Beam Java SDK. The function outputs a JSON string ofcom.google.cloud.spanner.DataChangeRecord, which is necessary asDataChangeRecordsare not yet directly supported, and existing solutions (like PubSub) rely on this string format.Required parameters include
instance_id,database_id,project_id,changeStreamName,inclusiveStartAt,metadataDatabase, andmetadataInstance.These changes align with the existing development for
ReadFromSpannerandWriteToSpannerSchemawithinapache_beam.io.gcp.spanner.Added unit test for the cross-language support for Spanner Change Stream.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.