Fix(java/sql): Fix NullPointerException in TextTableProvider for Java 17#35476
Fix(java/sql): Fix NullPointerException in TextTableProvider for Java 17#35476liferoad wants to merge 1 commit intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
left a comment
There was a problem hiding this comment.
The tests has been exercised on Java17 and passed. I also ran locally (with Java17 solely) ./gradlew :sdks:java:extensions:sql:test --tests org.apache.beam.sdk.extensions.sql.meta.provider.text.TextTableProviderTest test also passed. I'm using Temurin-17.0.8+7
Observed test failures might be due to unrelated issue like gradle cache etc
|
@damccorm also confirmed the tests work with his Java 17. Let me close this for now. |
The TextTableProvider was failing with a NullPointerException when using the JSON format on java 17:
Overriding the
buildIOWritermethod inTextJsonTableto correctly handle writing JSON files.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.