Skip to content

Conversation

@shunping
Copy link
Collaborator

Cherry-pick #36574 to fix flakiness in data generation.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses flakiness in data generation within the Apache Beam PeriodicSequence transform. It refines the timestamp calculation logic to guarantee that the start and end timestamps for rebased elements are perfectly synchronized, thereby enhancing the reliability of data generation processes.

Highlights

  • Timestamp Consistency: Ensured that the start and end timestamps in PeriodicSequence's REBASE_ALL mode are derived from a single call to Timestamp.now(), preventing potential flakiness due to slight time differences between two separate calls.
  • Walrus Operator Usage: Introduced the Python walrus operator (:=) to assign the result of Timestamp.now() to a variable now within a lambda function, allowing its reuse for both start and end timestamp calculations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping shunping changed the title Call now() once so start and end have exactly the same base timestamp (#36574) Cherry-pick #36574 Oct 21, 2025
@shunping
Copy link
Collaborator Author

R: @damccorm @Abacn @Amar3tto

@shunping shunping self-assigned this Oct 21, 2025
@shunping shunping changed the title Cherry-pick #36574 Cherry-pick into release 2.69 #36574 Oct 21, 2025
@shunping shunping changed the title Cherry-pick into release 2.69 #36574 Cherry-pick #36574 into release 2.69 Oct 21, 2025
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@shunping
Copy link
Collaborator Author

We will merge this if we are having 2.69 RC4. @Abacn

@shunping
Copy link
Collaborator Author

Since 2.69 has been released, this is no longer relevant.

@shunping shunping closed this Oct 29, 2025
@shunping shunping deleted the cp-36574 branch October 29, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant