make use of generic type info in *Utils classes

[tilgalas]

This is a 4th PR in the series of PRs (based on the now closed #31648) whose ultimate goal is to add support for generic classes to schema providers.

This PR replaces the uses of incomplete type information carried in TypeDescriptor.of invocations in the various *Utils classes with the full type signature stored in the FieldValueTypeInformation objects

[gemini-code-assist]

Summary of Changes

Hello @tilgalas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is the fourth in a series aimed at enabling full support for generic classes within Beam's schema providers. It focuses on refining how type information is accessed and utilized across various utility classes responsible for schema-related operations. By transitioning from potentially incomplete TypeDescriptor invocations to the more robust FieldValueTypeInformation, the changes ensure that type conversions, field access, and bytecode generation are performed with accurate and complete generic type signatures, laying essential groundwork for future generic class support.

Highlights

• Enhanced Type Information Usage: The pull request updates several *Utils classes (AutoValueUtils, ByteBuddyUtils, JavaBeanUtils, POJOUtils) to utilize the comprehensive generic type information provided by FieldValueTypeInformation objects. This replaces previous reliance on TypeDescriptor.of which could provide incomplete type signatures, especially for generic types.
• Refactoring of Setter Generation in POJOUtils: The logic for generating FieldValueSetter instances has been removed from POJOUtils.java, along with associated caching mechanisms and test cases. This indicates a significant refactoring or relocation of setter creation responsibilities.
• Improved Type Conversion and Casting: New type casting logic has been introduced in JavaBeanUtils.java and POJOUtils.java for getter implementations, ensuring correct type handling during bytecode generation. Additionally, ByteBuddyUtils.java now includes a primitiveToWrapper helper for more robust type conversions in collections and iterables.
• Streamlined API for Getter/Setter Implementations: Methods like implementGetterMethods in JavaBeanUtils.java and POJOUtils.java, and SetFieldCreateInstruction in POJOUtils.java, have been refactored to directly accept FieldValueTypeInformation lists or objects, simplifying their interfaces and promoting consistent type handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.93%. Comparing base (d0d0cd8) to head (9eebd65).
⚠️ Report is 108 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #36581   +/-   ##
=========================================
  Coverage     56.93%   56.93%           
- Complexity     3393     3395    +2     
=========================================
  Files          1222     1222           
  Lines        186813   186817    +4     
  Branches       3543     3545    +2     
=========================================
+ Hits         106362   106373   +11     
+ Misses        77079    77073    -6     
+ Partials       3372     3371    -1     

Flag	Coverage Δ
java	70.34% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[tilgalas]

Run Java PreCommit

[tilgalas]

Run Java_Amazon-Web-Services2_IO_Direct PreCommit

[tilgalas]

Run Java_IOs_Direct PreCommit

[github-actions]

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[github-actions]

Reminder, please take a look at this pr: @chamikaramj

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[kennknowles]

This mostly seems fine, I'm just still catching up on the design doc and everything and the new FieldValueTypeInformation vs TypeDescriptor. So I still have more like high level curiosity.

[kennknowles]

Please avoid Preconditions.checkNotNull - we've made better versions. Please use checkArgumentNotNull if the null error should be blamed on the caller, or checkStateNotNull if the null error should be blamed on this class.

[tilgalas]

got it, will fix

[tilgalas]

pushed an update - I had to change some additional lines containing the old-style checkNotNull invocations which made the PR somewhat larger- hopefully it's still relatively easy to scan those changes while doing the review

[tilgalas]

This mostly seems fine, I'm just still catching up on the design doc and everything and the new FieldValueTypeInformation vs TypeDescriptor. So I still have more like high level curiosity.

sure, thanks so much!

[tilgalas]

Run Java PreCommit

[tilgalas]

Run Java PreCommit

[github-actions]

Reminder, please take a look at this pr: @kennknowles