[yaml]: add kafka parameter explicitly and uncover kafka test#36603
[yaml]: add kafka parameter explicitly and uncover kafka test#36603derrickaw wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36603 +/- ##
=========================================
Coverage 40.21% 40.21%
Complexity 3394 3394
=========================================
Files 1222 1222
Lines 186913 186911 -2
Branches 3545 3545
=========================================
Hits 75174 75174
+ Misses 108367 108365 -2
Partials 3372 3372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
#36541 (comment) - runner is outdated, hence why postcommit is failing. Need to wait until that is fixed before making sure postcommit passes. |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
cb14874 to
7642727
Compare
|
Run Python_Coverage PreCommit 3.10 |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
max_read_time_seconds parameter is being sent down to the java provider as pass through. Just making the parameter explicit in the standard_io.py file.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.