Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 28, 2025

Reverts #36594

@github-actions github-actions bot added the build label Oct 28, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undoes a prior modification that enforced a particular Logback version across all transitive dependencies within the project's build configuration. The original change aimed to mitigate potential security vulnerabilities, but this revert removes that explicit version constraint, allowing the dependency resolution mechanism to determine the appropriate Logback versions.

Highlights

  • Revert Previous Change: This pull request fully reverts the changes introduced in Force logback version in transitive dependencies #36594, which previously forced a specific Logback version in transitive dependencies.
  • Dependency Version Removal: The logback_version variable, previously set to '1.5.20', has been removed from the BeamModulePlugin.groovy file.
  • Forced Dependency Management Removed: The explicit force declarations for ch.qos.logback:logback-classic and ch.qos.logback:logback-core have been removed, allowing the build system to resolve these dependencies without a forced version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 28, 2025

fix #33252, fix #36638

as a follow up, we should pin logback version in io-expansion-service and gcp-expansion-service module

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 29, 2025

going to merge this and open an alternative fix

@Abacn Abacn merged commit 1c5f0f3 into master Oct 29, 2025
17 checks passed
@Abacn Abacn deleted the revert-36594-logback-override branch October 29, 2025 15:19
@kennknowles
Copy link
Member

LGTM - thanks for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants