Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 28, 2025

Follow up Beam 2.69.0 release branch verification, see #36634 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Oct 28, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the organization and maintainability of the Apache Beam Java SDK's test suite. It achieves this by refactoring the ViewTest class, moving all tests pertaining to View.asMap() and View.asMultimap() functionalities into a newly created, specialized test file, MapViewTest.java. This change ensures that map-related view tests are consolidated, simplifying future test development and debugging.

Highlights

  • Test Refactoring: Extracted all tests related to View.asMap() and View.asMultimap() from ViewTest.java into a new, dedicated test file, MapViewTest.java.
  • New Test File: Introduced MapViewTest.java to house comprehensive tests for map and multimap side inputs, covering various scenarios like basic usage, entry set access, in-memory views, non-deterministic key coders, windowed inputs, empty views, immutability, and combined inputs.
  • Improved Organization: Enhanced the structure of the test suite by separating concerns, making it easier to locate and manage tests for specific View functionalities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Oct 29, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Oct 29, 2025

It seems beam_PreCommit_Java_PVR_Prism_Loopback is flaky (also flaky on master branch): https://github.com/apache/beam/actions/runs/18888383530/job/53909609623 cc: @shunping

@Abacn Abacn merged commit 55880d3 into apache:master Oct 29, 2025
19 of 22 checks passed
@Abacn Abacn deleted the splitviewtest branch October 29, 2025 17:46
@shunping
Copy link
Collaborator

It seems beam_PreCommit_Java_PVR_Prism_Loopback is flaky (also flaky on master branch): https://github.com/apache/beam/actions/runs/18888383530/job/53909609623 cc: @shunping

I checked a few failed instances, but I could not see a pattern. It may be caused by the heavy load in the test machines. Will keep an eye on them.

shunping added a commit to shunping/beam that referenced this pull request Oct 30, 2025
lostluck pushed a commit that referenced this pull request Oct 30, 2025
* Add comments about holding refreshCond lock when accessing processing time queue.

* Acquire lock before add pending. Unexport ProcessTimeNow in em.

* Remove unnecessary lock aquiring in startTriggeredBundle.

* Update the test to skip after #36655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants