Skip to content

Conversation

@Amar3tto
Copy link
Collaborator

Cherry-pick #36583 to post-release branch


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a cherry-pick to the post-release branch for version 2.69.0, primarily aimed at refining the Python SDK container's machine learning environment. It introduces a dedicated 'ml_cpu' dependency configuration to ensure that PyTorch and other ML libraries are installed using CPU-specific wheels. This change addresses potential licensing conflicts by preventing the inclusion of GPU-dependent packages and standardizes the ML dependency management across various Python versions within the Beam ecosystem.

Highlights

  • Introduction of ml_cpu Extra: A new 'ml_cpu' dependency group has been added to 'setup.py' to specifically manage CPU-only machine learning dependencies, providing a clear separation from GPU-enabled configurations.
  • CPU-only PyTorch Installation Enforcement: Build scripts ('Dockerfile', 'run_generate_requirements.sh') are updated to explicitly pull PyTorch dependencies from the PyTorch CPU wheel repository, preventing the inclusion of GPU-specific dependencies that might have licensing restrictions.
  • Updated ML Requirements Files: New 'ml_image_requirements.txt' files are generated for Python versions 3.9, 3.10, 3.11, and 3.12, and the existing one for 3.13 is updated. All these files now reflect the 'ml_cpu' dependencies and specifically list 'torch==2.8.0+cpu'.
  • Dependency Version Bumps: Several ML-related package versions have been updated across the requirements files, including 'cryptography', 'grpcio', 'hypothesis', 'idna', 'referencing', 'regex', 'wrapt', and 'yarl', ensuring compatibility and incorporating the latest stable versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damccorm
Copy link
Contributor

damccorm commented Oct 30, 2025

Checks still seem to be failing, but are unrelated to this pr. Running https://github.com/apache/beam/actions/runs/18949703006 to confirm that this also fails at head on this branch, but I'm not sure why this broke on the postrelease branch...

If that check also fails, this should be safe to merge

EDIT: That fails too, so I'll merge. I'm guessing we're running those tests when we shouldn't be somehow

@damccorm damccorm merged commit 07a65ad into release-2.69.0-postrelease Oct 30, 2025
310 of 345 checks passed
@damccorm damccorm deleted the release-2.69.0-postrelease-cp-36583 branch October 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants