Support portable decimal types for Beam SQL

[Abacn]

Tested with a yaml pipeline read from Jdbc table that includes a numeric column and apply a sql transform

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @Abacn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables Beam SQL to properly handle portable decimal types by integrating the FixedPrecisionNumeric logical type. This ensures that numeric data with fixed precision and scale can be accurately processed and transformed within SQL queries, addressing a critical need for robust data manipulation in Beam SQL.

Highlights

• FixedPrecisionNumeric Support: Introduced support for the FixedPrecisionNumeric logical type within Beam SQL's calculation engine.
• Data Retrieval: Enhanced the getBeamField method in BeamCalcRel to correctly retrieve values of FixedPrecisionNumeric type by calling getDecimal.
• Type Conversion: Implemented conversion logic in toCalciteValue to transform FixedPrecisionNumeric values into BigDecimal for seamless integration with Calcite's expression evaluation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Abacn]

R: @shunping

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[shunping]

Thanks! How about the other logical types, like JDBC Timestamp ones?

[Abacn]

Thanks! How about the other logical types, like JDBC Timestamp ones?

Attempted to cover these and realized it was more complicated (and messy), ended up adding a milestone to #28359 in hope to get rid of non-portable logical types defined in JdbcIO in Beam 3

[shunping]

LGTM. Would be great to add a test in YAML

[Abacn]

was trying to add one in apache_beam/yaml/tests/sql.yaml, but could not reproduce the issue on master branch. If I change the query to SELECT cast(id AS NUMERIC) as id_numeric, ... FROM PCOLLECTION and add SELECT id_numeric from PCOLLECTION it just works fine. It appears one needs some row with numeric that come from Java -> Python -> Sql so it became portable numeric logical type.