Skip to content

Conversation

@praneetnadella
Copy link
Contributor

This function is meant to be overridden.

Plan to replace similar to Dill through copybara.

Tested:

Added test_default_config_interceptor, a unit test verifying the calling of get_normalized_path.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Nov 6, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @praneetnadella, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the pickling mechanism by introducing file path normalization for code objects. By integrating get_normalized_path into the CloudPickleConfig, it ensures that file paths are consistently handled during serialization, which is crucial for environments where path variations could lead to issues. A dedicated test case validates this new behavior, confirming the correct application of the interceptor.

Highlights

  • CloudPickle Configuration Update: The CloudPickleConfig instances (DEFAULT_CONFIG, NO_DYNAMIC_CLASS_TRACKING_CONFIG, STABLE_CODE_IDENTIFIER_CONFIG) in cloudpickle_pickler.py have been updated to utilize a filepath_interceptor parameter, setting it to get_normalized_path.
  • File Path Normalization: The get_normalized_path function from code_object_pickler is now used to ensure consistent and normalized file paths during the pickling process of code objects.
  • New Unit Test: A new unit test, test_default_config_interceptor, has been added to cloudpickle_pickler_test.py to verify that the filepath_interceptor is correctly invoked when pickling code objects and that the unpickled code object retains its original, normalized filename.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@praneetnadella
Copy link
Contributor Author

R: @claudevdm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm
Copy link
Collaborator

Unit tests are failing https://github.com/apache/beam/runs/54642818003

@praneetnadella
Copy link
Contributor Author

praneetnadella commented Nov 6, 2025

Fixed those issues. Currently some transient issue with the RAT PreCommit which seems like a network issue?

@praneetnadella
Copy link
Contributor Author

R: @tvalentyn

@tvalentyn tvalentyn merged commit c750f8a into apache:master Nov 8, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants