Check that billing project is not null in BigQuerySourceBase

[clairemcginty]

When neither project nor bigQueryProject or set, a BigQueryIO read will fail on source split with the error:

Caused by: java.lang.NullPointerException: Required parameter projectId must be specified.
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:924)
	at com.google.api.client.util.Preconditions.checkNotNull(Preconditions.java:138)
	at com.google.api.services.bigquery.Bigquery$Jobs$Insert.<init>(Bigquery.java:2654)
	at com.google.api.services.bigquery.Bigquery$Jobs.insert(Bigquery.java:2593)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImpl$JobServiceImpl.startJob(BigQueryServicesImpl.java:378)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImpl$JobServiceImpl.startJob(BigQueryServicesImpl.java:363)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImpl$JobServiceImpl.startExtractJob(BigQueryServicesImpl.java:318)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQuerySourceBase.executeExtract(BigQuerySourceBase.java:218)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQuerySourceBase.extractFiles(BigQuerySourceBase.java:137)
	at org.apache.beam.sdk.io.gcp.bigquery.BigQuerySourceBase.split(BigQuerySourceBase.java:157)
	at 

(strange that the job doesn't fail earlier, but 😅 )

This is a confusing error message for the user because it implies that a param like --projectId is required, when really it's just derived in BigQuerySourceBase from either the --project/--bigQueryProject param.

This PR just adds a null check earlier along in the stack trace that's more actionable for the Beam user.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @clairemcginty, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and user-friendliness of BigQueryIO operations by proactively validating the presence of a billing project. Previously, a missing project configuration would result in a cryptic NullPointerException deep within the stack. The change ensures that users receive a clear and direct error message, guiding them to correctly configure the necessary project parameters, thereby streamlining debugging and improving the overall developer experience.

Highlights

• Improved Error Handling: Addresses a NullPointerException that occurred when neither project nor bigQueryProject were set for BigQueryIO reads, leading to a confusing error message.
• Actionable Error Message: Introduces an earlier null check for the billing project in BigQuerySourceBase, providing a more actionable error message that guides users to set either --bigQueryProject or --project.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[ahmedabu98]

Thanks @clairemcginty, the error message improvement is good.

It still runs during runtime though correct? I wonder if we can check and throw earlier, maybe during expansion time?

[Abacn]

Note that there is a recent fix #36694 not yet released. Looks like it is not sufficient either.

Shall we fallback to BigQuery dataset project if not set in pipeline options?

maybe during expansion time?

There is a risk that some use case succeeded before will fail now.

[github-actions]

Reminder, please take a look at this pr: @ahmedabu98

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @chamikaramj

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[github-actions]

Reminder, please take a look at this pr: @Abacn

[ahmedabu98]

maybe during expansion time?

There is a risk that some use case succeeded before will fail now.

Those use-cases should also be failing though right? project id is required here for a successful read

[ahmedabu98]

Either way, I think this is a good PR to merge.

Further improvement can be to add a check in expansion time.