Add kafka read override to Dataflow java runner. #36849
Conversation
|
R: @scwhittle |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
...w-java/src/main/java/org/apache/beam/runners/dataflow/KafkaReadWithRedistributeOverride.java
Outdated
Show resolved
Hide resolved
...va/src/test/java/org/apache/beam/runners/dataflow/KafkaReadWithRedistributeOverrideTest.java
Show resolved
Hide resolved
scwhittle
left a comment
scwhittle
left a comment
There was a problem hiding this comment.
just some some minor comments
...w-java/src/main/java/org/apache/beam/runners/dataflow/KafkaReadWithRedistributeOverride.java
Outdated
Show resolved
Hide resolved
...va/src/test/java/org/apache/beam/runners/dataflow/KafkaReadWithRedistributeOverrideTest.java
Outdated
Show resolved
Hide resolved
...va/src/test/java/org/apache/beam/runners/dataflow/KafkaReadWithRedistributeOverrideTest.java
Show resolved
Hide resolved
… once, refine suppressed lint warnings to just instanceof on matches method.
|
Assigning reviewers: R: @kennknowles added as fallback since no labels match configuration Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| overridesBuilder.add( | ||
| PTransformOverride.of( | ||
| KafkaReadWithRedistributeOverride.matcher(), | ||
| new KafkaReadWithRedistributeOverride.Factory())); |
There was a problem hiding this comment.
ideally move Override to KafkaIO as KafkaIO.Read.KAFKA_READ_OVERRIDE above. This keeps reference to KafkaIO for DataflowRunner minimum (ease import)
There was a problem hiding this comment.
Ah, sorry about that. @tomstepp can you send a follow-up PR to move this?
There was a problem hiding this comment.
Sorry, yeah I can update this, thanks for identifying the improvement @Abacn !
3 participants
Add kafka read override to Dataflow java runner.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.