Skip to content

Conversation

@claudevdm
Copy link
Collaborator

Arrow timestamp nanoseconds maps to beam timestamp logical type with nanosecond precision, which is backed by java.time.Instant.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Collaborator Author

R: @Abacn

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @claudevdm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the Apache Beam Arrow extension to fully support timestamp values with nanosecond precision. It addresses a gap where only millisecond and microsecond precision timestamps were explicitly handled, ensuring that Arrow's nanosecond timestamp logical type is correctly mapped to Beam's java.time.Instant backed nanosecond timestamp. This enhancement improves data fidelity and compatibility when exchanging timestamp data between Arrow and Beam, allowing for more granular time representations.

Highlights

  • Nanosecond Timestamp Support: Added support for converting Arrow timestamp logical types with nanosecond precision to Beam's Timestamp.NANOS logical type, which is backed by java.time.Instant.
  • Schema Conversion Logic: Modified the ArrowConversion utility to correctly map Arrow TimeUnit.NANOSECOND to Beam's nanosecond timestamp logical type during schema translation.
  • Data Conversion Logic: Implemented the necessary logic to convert epoch nanosecond values from Arrow to java.time.Instant objects when reading data.
  • New Test Cases: Introduced a dedicated test case to verify the correct schema conversion for nanosecond timestamps and updated an existing integration test to include nanosecond timestamp data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@claudevdm
Copy link
Collaborator Author

R: @ahmedabu98

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@ahmedabu98 ahmedabu98 merged commit 712172d into apache:master Dec 3, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants