-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix Javadoc Unicode rendering issue with RIGHT SINGLE QUOTATION MARK #36964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add docencoding UTF-8 option to Javadoc configuration in BeamModulePlugin - Replace U+2019 (RIGHT SINGLE QUOTATION MARK) with ASCII apostrophe in source files - Fixes rendering issue where Unicode apostrophes show as â in generated Javadoc Fixes rendering of text like 'doesn't' which was showing as 'doesnât' in HTML output.
Summary of ChangesHello @Arunodoy18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a Javadoc rendering issue where Unicode apostrophes were displayed incorrectly. It resolves this by standardizing Javadoc encoding configurations to UTF-8 across the build system and by replacing specific Unicode quotation marks with their ASCII equivalents in relevant source files. These changes ensure that generated documentation displays special characters correctly, improving readability and consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
|
Thanks, I understand this fixes #25427 ? Not sure how KafkaIO.java get touched (and caused spotless check failure). Consider reverting unrelated changes? |
|
Fixes #25427 SummaryThis PR fixes the issue described in #25427 where . Changes in This PR
No other files were modified. Validation
Notes for Reviewers
Please let me know if additional test coverage or documentation updates are needed. During investigation, I confirmed that modifying This PR now focuses solely on the fix for #25427. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| @@ -1,4 +1,4 @@ | |||
| /* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using LLM, please check your changes manually both new commits and the generated reply. The unrelated changes are still present
Fixes rendering of text like 'doesn't' which was showing as 'doesnât' in HTML output.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.