Skip to content

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Dec 3, 2025

The previous CSP fix failed because the newly added js and css files were not found.

GET https://beam.apache.org/css/fontawesome/release-v5.4.1.css net::ERR_ABORTED 404 (Not Found)
GET https://beam.apache.org/css/swiper@8/swiper-bundle.min.css net::ERR_ABORTED 404 (Not Found)
GET https://beam.apache.org/css/roboto/roboto.css net::ERR_ABORTED 404 (Not Found)
GET https://beam.apache.org/js/jquery/jquery-2.2.4.min.js net::ERR_ABORTED 404 (Not Found)

This PR fixes these references.

fixes #36622

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the website's security posture and optimizing resource loading by addressing Content Security Policy (CSP) and external asset management. It transitions several commonly used CSS and JavaScript libraries from external CDN sources to local hosting, thereby reducing external dependencies. Concurrently, the CSP rules have been refined to ensure that necessary external services, such as social media widgets and analytics, continue to function correctly without compromising security.

Highlights

  • Content Security Policy (CSP) Update: The Content Security Policy configuration in the .htaccess file has been re-evaluated and updated to correctly allow necessary external domains for embedded content and fonts, ensuring compliance with Apache's CSP guidelines.
  • External Dependency Localization: Several key CSS and JavaScript libraries, including Roboto fonts, Font Awesome, Swiper, and jQuery, have been moved from external CDN links to locally hosted files within the repository. This improves asset loading and reduces reliance on third-party services.
  • Build Configuration Adjustment: The build.gradle.kts file was updated to include the new local CSS assets in the exclusions for the Apache Rat tool, preventing license header checks on these third-party minified files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping shunping requested a review from damccorm December 3, 2025 17:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Assigning reviewers:

R: @damccorm for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, we can try again and monitor/rollback if needed

@shunping shunping merged commit fc673aa into apache:master Dec 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Content-Security-Policy header must not be overridden

2 participants