Support Vertex Flex API in GeminiModelHandler #36982

dannikay · 2025-12-03T17:50:47Z

No description provided.

github-actions · 2025-12-03T19:35:41Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

dannikay · 2025-12-03T23:17:32Z

assign set of reviewers

github-actions · 2025-12-03T23:18:45Z

Assigning reviewers:

R: @tvalentyn for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

tvalentyn · 2025-12-04T20:12:29Z

Thanks!

@jrmccluskey would you recommedn we also add an integration test in sdks/python/apache_beam/ml/inference/gemini_inference_it_test.py ?
There is a linter error

Running pylint...
************* Module apache_beam.ml.inference.gemini_inference_test
apache_beam/ml/inference/gemini_inference_test.py:20:0: W0611: Unused mock imported from unittest (unused-import)

jrmccluskey · 2025-12-04T20:15:40Z

Seems like adding a small integration test case would be reasonable for this, just as an extra sanity check

dannikay · 2025-12-04T20:45:20Z

Seems like adding a small integration test case would be reasonable for this, just as an extra sanity check

Integration testing isn't possible at the moment:

The API is not publicly available
Project apache-beam-testing is not yet allowlisted
We're not allowed to do automated testing against their non-public API (oneoff is fine but you need to jump through hoops to get allowlisted)

We can add one once the API is launched publicly. WDYT?

dannikay · 2025-12-04T20:50:46Z

Thanks!

@jrmccluskey would you recommedn we also add an integration test in sdks/python/apache_beam/ml/inference/gemini_inference_it_test.py ?

There is a linter error

Running pylint... ************* Module apache_beam.ml.inference.gemini_inference_test apache_beam/ml/inference/gemini_inference_test.py:20:0: W0611: Unused mock imported from unittest (unused-import)

Removed the unused mock. Not sure why "tox -e py3-yapf" is not remove this line.

tvalentyn · 2025-12-04T21:05:43Z

yapf changes formatting but doesn't modify content semantically.

tvalentyn · 2025-12-04T21:07:21Z

actually mypy is still failing.

2025-12-04T21:05:36.1516076Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "api_version" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1517488Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1518654Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "headers" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1519875Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1520949Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "timeout" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1522892Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1524279Z apache_beam/ml/inference/gemini_inference.py:193: error: Argument "http_options" to "Client" has incompatible type "ClientOptions"; expected "HttpOptions | HttpOptionsDict | None"  [arg-type]

dannikay · 2025-12-04T21:38:45Z

python -m pytest apache_beam/ml/inference/gemini_inference_test.py

Successfully set waiting utils config
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.13.5, pytest-8.3.4, pluggy-1.6.0
configfile: pytest.ini
plugins: timeout-2.4.0, xdist-3.8.0, requests-mock-1.12.1, hypothesis-6.148.3, anyio-4.12.0
timeout: 600.0s
timeout method: signal
timeout func_only: False
collected 8 items

apache_beam/ml/inference/gemini_inference_test.py ........ [100%]

================================================================================================ 8 passed in 3.32s ================================================================================================

dannikay · 2025-12-04T21:40:17Z

actually mypy is still failing.

2025-12-04T21:05:36.1516076Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "api_version" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1517488Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1518654Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "headers" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1519875Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1520949Z apache_beam/ml/inference/gemini_inference.py:193: error: Unexpected keyword argument "timeout" for "ClientOptions"  [call-arg]
2025-12-04T21:05:36.1522892Z target/.tox-mypy/mypy/lib/python3.10/site-packages/google/api_core/client_options.py:107: note: "ClientOptions" defined here
2025-12-04T21:05:36.1524279Z apache_beam/ml/inference/gemini_inference.py:193: error: Argument "http_options" to "Client" has incompatible type "ClientOptions"; expected "HttpOptions | HttpOptionsDict | None"  [arg-type]

The ClientOption was swapped somehow by some autocompletion tool. I should have checked more thoroughly. Now verified locally that all unit tests pass.

tvalentyn · 2025-12-04T22:35:27Z

there is still a linter error FYI.

dannikay · 2025-12-04T22:47:47Z

there is still a linter error FYI.

it complains about this import syntax:

+++ /runner/_work/beam/beam/sdks/python/test-suites/tox/pycommon/build/srcs/sdks/python/apache_beam/ml/inference/gemini_inference.py:after	2025-12-04 21:47:38.526115
@@ -25,7 +25,8 @@
 
 from google import genai
 from google.genai import errors
-from google.genai.types import HttpOptions, Part
+from google.genai.types import HttpOptions
+from google.genai.types import Part
 from PIL.Image import Image

my local check passed:

yapf --diff apache_beam/ml/inference/gemini_inference.py
(base) xiaochu@xiaochu:~/github/beam/sdks/python$ pylint apache_beam/ml/inference/gemini_inference.py

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

But anyway let me follow the check's preference.

tvalentyn · 2025-12-04T22:52:15Z

yeah, isort is a separate check.

you might be able to also run gradlew lint locally.

@jrmccluskey do you by chance have instructions for running isort locally, similar to https://github.com/apache/beam/blob/master/contributor-docs/python-tips.md#running-yapf-formatter-manually ?

dannikay · 2025-12-05T03:08:35Z

The remaining one failed check seems to be a flake:

Prepare all required actions
Getting action download info
Download action repository 'actions/setup-python@v5' (SHA:a26af69be951a213d495a4c3e4e4022e16d87065)
Download action repository 'actions/cache@v3' (SHA:6f8efc29b200d32929f49075959781ed54ec270c)
Download action repository 'actions/setup-java@v3' (SHA:17f84c3641ba7b8f6deff6309fc4c864478f5d62)
Download action repository 'gradle/gradle-build-action@v2' (SHA:a8f75513eafdebd8141bd1cd4e30fcd194af8dfa)
Download action repository 'actions/setup-go@v6' (SHA:4dc6199c7b1a012772edbd06daecab0f50c9053c)
Run ./.github/actions/setup-environment-action
Run actions/setup-python@v5
Installed versions
  Version 3.11 was not found in the local cache
  Version 3.11 is available for downloading
  Download from "https://github.com/actions/python-versions/releases/download/3.11.12-14343939122/python-3.11.12-linux-20.04-x64.tar.gz"
  Unexpected HTTP response: 404
  Error: Unexpected HTTP response: 404

This reverts commit 72e84ef.

Support Vertex Flex API in GeminiModelHandler

8329b52

github-actions bot added the python label Dec 3, 2025

Fix lint errors.

55f35ab

github-actions bot added the Next Action: Reviewers label Dec 3, 2025

Fix lint.

e3161fe

tvalentyn approved these changes Dec 4, 2025

View reviewed changes

dannikay added 2 commits December 4, 2025 21:34

Import the correct HttpOptions

2a77e9d

Fix the unit test so it runs successfully.

8811991

Fix lint again.

9964216

tvalentyn merged commit 72e84ef into apache:master Dec 5, 2025
100 of 101 checks passed

apache deleted a comment from gemini-code-assist bot Dec 8, 2025

dannikay added a commit to dannikay/beam that referenced this pull request Dec 8, 2025

Revert "Support Vertex Flex API in GeminiModelHandler (apache#36982)"

9b33ee8

This reverts commit 72e84ef.

dannikay mentioned this pull request Dec 8, 2025

Revert "Support Vertex Flex API in GeminiModelHandler" #37051

Merged

damccorm pushed a commit that referenced this pull request Dec 8, 2025

Revert "Support Vertex Flex API in GeminiModelHandler (#36982)" (#37051)

585ad41

This reverts commit 72e84ef.

Support Vertex Flex API in GeminiModelHandler #36982

Support Vertex Flex API in GeminiModelHandler #36982

Conversation

dannikay commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

dannikay commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

tvalentyn commented Dec 4, 2025

Uh oh!

jrmccluskey commented Dec 4, 2025

Uh oh!

dannikay commented Dec 4, 2025

Uh oh!

dannikay commented Dec 4, 2025

Uh oh!

tvalentyn commented Dec 4, 2025

Uh oh!

tvalentyn commented Dec 4, 2025

Uh oh!

dannikay commented Dec 4, 2025

Uh oh!

dannikay commented Dec 4, 2025

Uh oh!

tvalentyn commented Dec 4, 2025

Uh oh!

dannikay commented Dec 4, 2025

Uh oh!

tvalentyn commented Dec 4, 2025

Uh oh!

dannikay commented Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants