Skip to content

Conversation

@scwhittle
Copy link
Contributor

Add integration tests of WithOutputTimestamp and WithNoOutputTimestamp


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the go label Dec 9, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @scwhittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Apache Beam Go SDK by adding a WithNoOutputTimestamp option for timers. This new option provides more control over watermark progression by allowing timers to fire without explicitly setting an output timestamp, ensuring that elements emitted from such timers default to MaxTimestamp. The change is supported by new integration tests that verify the correct behavior of timers with and without explicit output timestamps, ensuring consistency and reliability.

Highlights

  • New Timer Option: Introduced WithNoOutputTimestamp to the Go SDK's timer functionality, allowing timers to be set without holding up the output watermark, aligning with the Java SDK's capabilities.
  • Integration Tests: Added comprehensive integration tests to validate the behavior of both WithOutputTimestamp and the newly added WithNoOutputTimestamp for event time timers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Assigning reviewers:

R: @lostluck for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor

lostluck commented Dec 9, 2025

Run Go PostCommit

@lostluck
Copy link
Contributor

lostluck commented Dec 9, 2025

If that comment doesn't work, touch .github/trigger_files/beam_PostCommit_Go.json and add it to the PR.

Per https://github.com/apache/beam/tree/master/.github/workflows#postcommit-jobs

The PR passes against Prism, which is a decent sign, but for timers, it's best to validate against Dataflow just in case.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than checking against Dataflow.

@scwhittle
Copy link
Contributor Author

Thanks! I added the trigger file and the tests are passing so merging.

@scwhittle scwhittle merged commit 314d040 into apache:master Dec 10, 2025
8 checks passed
@scwhittle scwhittle deleted the golang_timer branch December 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants