-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Catch breaking import error #37295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch breaking import error #37295
Conversation
Summary of ChangesHello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical import error that previously occurred in environments lacking the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Run Python_Runners PreCommit 3.12 |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Catch Import Error * import order
* Support for RateLimiter in Beam Remote Model Handler (#37218) * Support for EnvoyRateLimiter in Apache Beam * fix format issues * fix test formatting * Fix test and syntax * fix lint * Add dependency based on python version * revert setup to separete pr * fix lint * fix formatting * resolve comments * Support Ratelimiter through RemoteModelHandler * fix lint * fix lint * fix comments * Add custom RateLimited Exception * fix doc * fix test * fix lint * update RateLimiter execution function name (#37287) * Catch breaking import error (#37295) * Catch Import Error * import order
Fix breaking import in internal repo which does not contain envoy-rate-limiter.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.