Skip to content

[typescript] - fix rest of vulnerabilities#37852

Open
derrickaw wants to merge 1 commit intoapache:masterfrom
derrickaw:20260313_npmVulnerabilities
Open

[typescript] - fix rest of vulnerabilities#37852
derrickaw wants to merge 1 commit intoapache:masterfrom
derrickaw:20260313_npmVulnerabilities

Conversation

@derrickaw
Copy link
Collaborator

@derrickaw derrickaw commented Mar 13, 2026

  1. Previous PR fix non-breaking TS vulnerabilities #37826 fixed the non-breaking changes.
  2. This PR fixes everything else that would cause one test failure, which is fixed.
  3. Results:

(3.11env) beam/sdks/typescript$ npm install

up to date, audited 381 packages in 842ms

63 packages are looking for funding
run npm fund for details

found 0 vulnerabilities

(3.11env) beam/sdks/typescript$ npm audit
found 0 vulnerabilities


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the security posture of the TypeScript SDK by performing a comprehensive update of its npm dependencies. The changes involve bumping versions for various packages, including core Google Cloud libraries and gRPC, and introducing explicit version overrides for transitive dependencies to mitigate potential vulnerabilities. Additionally, a test assertion was updated to be more robust against minor structural changes in objects.

Highlights

  • Dependency Updates: Updated numerous npm package dependencies in the TypeScript SDK to address reported vulnerabilities, ensuring a more secure build environment.
  • Explicit Dependency Overrides: Introduced explicit 'overrides' in package.json for several transitive dependencies (js-yaml, serialize-javascript, @tootallnate/once, diff) to enforce specific, secure versions.
  • Test Refinement: Refined the assertion logic in 'primitives_test.ts' for PCollectionCoder, switching from deep equality checks to more specific property-based assertions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/typescript/package-lock.json
    • Updated versions for numerous direct and transitive npm dependencies, including @google-cloud/pubsub, @grpc/grpc-js, @google-cloud/precise-date, @opentelemetry/api, @opentelemetry/semantic-conventions, google-gax, proto3-json-serializer, serialize-javascript, yargs, and yargs-parser.
    • Downgraded 'codecov' and 'urlgrey' to earlier versions.
    • Added 'dev: true' and 'license' fields to many dependency entries.
  • sdks/typescript/package.json
    • Updated the version of 'codecov' to '^3.6.2'.
    • Updated the version of '@google-cloud/pubsub' to '^4.2.0'.
    • Updated the version of '@grpc/grpc-js' to '^1.14.3'.
    • Added an 'overrides' section to enforce specific versions for 'js-yaml', 'serialize-javascript', '@tootallnate/once', and 'diff'.
  • sdks/typescript/test/primitives_test.ts
    • Modified the assertion for PCollectionCoder to use individual 'assert.equal' checks on constructor names and nested coders instead of 'assert.deepEqual'.
Activity
  • The author, derrickaw, initiated this pull request to address vulnerabilities in the TypeScript SDK dependencies.
  • The PR description includes output from 'npm audit' confirming 'found 0 vulnerabilities' after the changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw marked this pull request as ready for review March 13, 2026 17:37
@github-actions
Copy link
Contributor

Assigning reviewers:

R: @chamikaramj added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant