Fix #37833: Use named logger instead of root logger in transforms/util.py#37857
Fix #37833: Use named logger instead of root logger in transforms/util.py#37857liferoad wants to merge 1 commit intoapache:masterfrom
Conversation
…ms/util.py Replace root logger calls (logging.info, logging.warning, etc.) with a module-level named logger (_LOGGER = logging.getLogger(__name__)) in apache_beam.transforms.util. This allows sdk_harness_log_level_overrides to properly control log levels for this module.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the logging implementation within Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
What
Fixes #37833
apache_beam.transforms.utilwas using the root logger (logging.info(...),logging.warning(...), etc.) instead of a module-level named logger. This preventedsdk_harness_log_level_overridesfrom controlling log levels for this module (e.g., suppressing the verboseBatchElements statisticsmessage at line 1029).Changes
_LOGGER = logging.getLogger(__name__)after imports_LOGGERcallsThis is consistent with other modules like
apache_beam.transforms.corewhich already use_LOGGER = logging.getLogger(__name__).How it was tested
Minimal change — only replaces the logger object used. No behavioral change unless
sdk_harness_log_level_overridesis configured, in which case named logger overrides will now correctly apply toapache_beam.transforms.util.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: