Skip to content

[BigQueryIO] Support reading from empty tables using Storage Read API in streaming pipelines#38009

Open
stankiewicz wants to merge 3 commits intoapache:masterfrom
stankiewicz:fix_bq_empty_table
Open

[BigQueryIO] Support reading from empty tables using Storage Read API in streaming pipelines#38009
stankiewicz wants to merge 3 commits intoapache:masterfrom
stankiewicz:fix_bq_empty_table

Conversation

@stankiewicz
Copy link
Copy Markdown
Contributor

This PR fixes an issue where BigQueryIO.read().withMethod(Method.DIRECT_READ) fails with an UnsupportedOperationException when reading from an empty table in a streaming pipeline.

In streaming pipelines, a BoundedSource (like BigQuery Storage Read) is wrapped in UnboundedReadFromBoundedSource. When the Storage Read API returns no streams (e.g., for an empty table or when all rows are pruned), the split() method returns an empty list.

The UnboundedReadFromBoundedSource adapter handles an empty split list by falling back to the original source and calling its createReader() method. Previously, BigQueryStorageSourceBase always threw UnsupportedOperationException in createReader(), assuming it must always be split first.

Changes

  • Updated BigQueryStorageSourceBase.createReader() to return a new EmptyReader if split() confirms there are no streams to read.
  • Added a private EmptyReader implementation that gracefully handles the absence of data.
  • Preserved the UnsupportedOperationException fallback for cases where split() fails or returns data, ensuring backward compatibility with existing tests and runner expectations for non-empty sources.
  • Added testUnboundedReadFromBoundedSourceWithEmptyTable to BigQueryIOStorageReadTest to specifically reproduce and verify this scenario.

Fixes #38007


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a runtime exception that occurs when using the BigQuery Storage Read API in streaming pipelines with empty tables. By introducing a specialized reader for empty sources, the system can now correctly handle scenarios where no data streams are returned, ensuring robust behavior without breaking existing functionality for non-empty sources.

Highlights

  • Empty Table Handling: Updated BigQueryStorageSourceBase.createReader() to return an EmptyReader when split() indicates no data is available, preventing an UnsupportedOperationException.
  • EmptyReader Implementation: Introduced a private EmptyReader class to gracefully handle reading from empty BigQuery tables in streaming pipelines.
  • Regression Testing: Added testUnboundedReadFromBoundedSourceWithEmptyTable to verify that empty tables no longer cause pipeline failures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@stankiewicz
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies BigQueryStorageSourceBase to handle empty data sources by returning an EmptyReader instead of throwing an UnsupportedOperationException. This is determined by attempting a split and checking if the result is empty. A new test case in BigQueryIOStorageReadTest verifies this behavior. The review feedback recommends adding debug logging when catching exceptions during the split check to prevent silent failures of underlying issues like authentication or quota errors.

@stankiewicz
Copy link
Copy Markdown
Contributor Author

Run Java_GCP_IO_Direct PreCommit

…am/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@stankiewicz
Copy link
Copy Markdown
Contributor Author

flakes around not related:


> Task :sdks:java:io:google-cloud-platform:integrationTest
StorageApiSinkSchemaUpdateIT > testExactlyOnceWithAutoSchemaUpdate[0] FAILED
    com.google.api.client.googleapis.json.GoogleJsonResponseException at StorageApiSinkSchemaUpdateIT.java:554
StorageApiSinkSchemaUpdateIT > testAtLeastOnceWithIgnoreUnknownValues[1] FAILED
    java.lang.RuntimeException at StorageApiSinkSchemaUpdateIT.java:554
        Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException at StorageApiSinkSchemaUpdateIT.java:554
StorageApiSinkSchemaUpdateIT > testAtLeastOnceDynamicDestinationsWithAutoSchemaUpdate[2] FAILED
    java.lang.RuntimeException at StorageApiSinkSchemaUpdateIT.java:530
        Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException at StorageApiSinkSchemaUpdateIT.java:530

@stankiewicz
Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: BigQueryIO DIRECT_READ breaks for empty table during Bounded-to-Unbounded conversion

2 participants