[BigQueryIO] Support reading from empty tables using Storage Read API in streaming pipelines#38009
[BigQueryIO] Support reading from empty tables using Storage Read API in streaming pipelines#38009stankiewicz wants to merge 3 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a runtime exception that occurs when using the BigQuery Storage Read API in streaming pipelines with empty tables. By introducing a specialized reader for empty sources, the system can now correctly handle scenarios where no data streams are returned, ensuring robust behavior without breaking existing functionality for non-empty sources. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request modifies BigQueryStorageSourceBase to handle empty data sources by returning an EmptyReader instead of throwing an UnsupportedOperationException. This is determined by attempting a split and checking if the result is empty. A new test case in BigQueryIOStorageReadTest verifies this behavior. The review feedback recommends adding debug logging when catching exceptions during the split check to prevent silent failures of underlying issues like authentication or quota errors.
...ud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java
Outdated
Show resolved
Hide resolved
|
Run Java_GCP_IO_Direct PreCommit |
…am/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
flakes around not related: |
|
assign set of reviewers |
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This PR fixes an issue where BigQueryIO.read().withMethod(Method.DIRECT_READ) fails with an UnsupportedOperationException when reading from an empty table in a streaming pipeline.
In streaming pipelines, a BoundedSource (like BigQuery Storage Read) is wrapped in UnboundedReadFromBoundedSource. When the Storage Read API returns no streams (e.g., for an empty table or when all rows are pruned), the split() method returns an empty list.
The UnboundedReadFromBoundedSource adapter handles an empty split list by falling back to the original source and calling its createReader() method. Previously, BigQueryStorageSourceBase always threw UnsupportedOperationException in createReader(), assuming it must always be split first.
Changes
Fixes #38007
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.