[#37994] Fix NullPointerException in Spark Runner with multiple outputs and serialization

[stankiewicz]

When using Spark StorageLevels that require serialization (e.g., MEMORY_AND_DISK_SER). the Spark Runner would fail with a NullPointerException if a ParDo had unconsumed outputs. This occurred because unconsumed outputs are pruned from the coder map, leaving them without a coder during the RDD encoding phase.

This fix:

• Updates TranslationUtils.getTupleTagEncodeFunction to return null for tags without a coder.
• Adds non-null filtering before RDD persistence in TransformTranslator, StatefulStreamingParDoEvaluator, and StreamingTransformTranslator to gracefully skip these unconsumed outputs.
• Added a regression test in TransformTranslatorTest to verify the fix with multiple outputs and serialization enabled.
  Fixes [Bug]: Apache Beam Managed Iceberg IO Does not work with Spark Serialization #37994

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a NullPointerException in the Spark Runner that occurs when using storage levels requiring serialization, specifically when a ParDo operation has unconsumed outputs. The fix ensures that these unconsumed outputs are correctly identified and skipped during the encoding phase, preventing the runner from attempting to access missing coders.

Highlights

• NullPointerException Fix: Updated TranslationUtils to return null for tags without a coder, preventing crashes when unconsumed outputs are encountered.
• RDD Persistence Optimization: Added non-null filtering in TransformTranslator, StatefulStreamingParDoEvaluator, and StreamingTransformTranslator to gracefully skip unconsumed outputs during RDD persistence.
• Regression Testing: Added a new test case in TransformTranslatorTest to verify correct behavior with multiple outputs and serialization enabled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses potential NullPointerExceptions in the Spark runner by correctly handling unconsumed side outputs during serialization. It modifies the encoding logic to return null when a coder is missing for an unconsumed output and introduces null filters across several translation classes to skip these entries. A new test case validates this behavior under forced serialization. Review feedback suggests refining a code comment for technical accuracy regarding unconsumed outputs and ensuring consistent single-line formatting for comments.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[github-actions]

Assigning reviewers:

R: @jrmccluskey added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[stankiewicz]

R: @twosom maybe

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[twosom]

Hi, @stankiewicz
thank you for your contribution! The changes look great to me.

However, I don't have the permissions to formally review or approve this PR. I'll tag someone who can help you further.

R: @Abacn

P.S. It might be better to commit by modifying the files under .github/trigger_files. You can refer to my PR for an example of how to do this.

[twosom]

Hi, @stankiewicz
thank you for your contribution! The changes look great to me.

However, I don't have the permissions to formally review or approve this PR. I'll tag someone who can help you further.

R: @Abacn

P.S. It might be better to commit by modifying the files under .github/trigger_files. You can refer to my PR for an example of how to do this.

[twosom]

Run Spark ValidatesRunner

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.75%. Comparing base (90a7db1) to head (5573fbc).
⚠️ Report is 52 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #38011      +/-   ##
============================================
- Coverage     54.75%   54.75%   -0.01%     
  Complexity     1690     1690              
============================================
  Files          1063     1063              
  Lines        166896   166891       -5     
  Branches       1226     1226              
============================================
- Hits          91381    91376       -5     
  Misses        73319    73319              
  Partials       2196     2196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.