Extending WindowedValue with ElementMetadata#35152
Closed
stankiewicz wants to merge 33 commits intoapache:masterfrom
Closed
Extending WindowedValue with ElementMetadata#35152stankiewicz wants to merge 33 commits intoapache:masterfrom
stankiewicz wants to merge 33 commits intoapache:masterfrom
Conversation
The DequeCoder uses ArrayDeque internally, which disallows null elements. We could switch Deque implementations, but this change is better. To quote the JDK docs: "While Deque implementations are not strictly required to prohibit the insertion of null elements, they are strongly encouraged to do so. Users of any Deque implementations that do allow null elements are strongly encouraged not to take advantage of the ability to insert nulls. This is so because null is used as a special return value by various methods to indicated that the deque is empty."
3 tasks
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
Run Java PreCommit |
Fix Java Example ARM PostCommit
Co-authored-by: Bulat Safiullin <v-safiullinb@microsoft.com>
The following mostly-automated changes: - Moved WindowedValue from util to values package - Make WindowedValue an interface with companion class WindowedValues
…e#35119) * move precommit yaml xlang to postcommit * add json file to trigger path * update pull request targets * add readme workflow changes * add cloud sdk setup * switch out to ubuntu-latest * add back precommit workflow * switch names and add postcommit * switch out to postCommitYamlIT * add test_files_dir flag * add conftest.py file for capturing directory flag * shift yaml tests around to appropriate locations * add back precommit to readme * add license for conftest.py * revert precommit to previous name * remove github.event.comment.body trigger
* Remove usages of deprecated pkg_resources package * use stdlib importlib.resources * remove extra comma * linting * import order
…#35156) * Create test * Implement new error message * Add beam.Create into unit test pipeline
…apache#35160) * add friendly error message for when transform is applied to no output * update test name * Fix pubsub unit tests that depend on old behavior
apache#34996) * Add warning if temp location bucket has soft delete enabled for Go SDK (resolves apache#31606) * Corrected Formatting * Applied suggested changes
… as it does not support nulls
…n cloudpickle.load (apache#35063) * Fix class states overwritten after cloudpickle.load * Fix further * Fix lint
* update postgres test without driver_class_name * update readme on how to run integration tests * fix misspelling * fix trailing whitespace
…gotiation' into element_metadata_capabilities_negotiation # Conflicts: # runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/BatchViewOverrides.java # runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/ValueInEmptyWindows.java # sdks/java/core/src/main/java/org/apache/beam/sdk/values/WindowedValues.java
github-actions
bot
added
python
go
build
website
io
extensions
spark
direct
gcp
core
flink
fn-execution
jet
local
samza
euphoria
twister2
yaml
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Following #34971
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.