Skip to content

Commit 2490683

Browse files
author
wenbingshen
committed
fix writeLac memory leak
1 parent 3a5cf9d commit 2490683

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919

2020
import java.util.BitSet;
2121
import java.util.List;
22+
23+
import io.netty.util.ReferenceCountUtil;
2224
import org.apache.bookkeeper.client.AsyncCallback.AddLacCallback;
2325
import org.apache.bookkeeper.net.BookieId;
2426
import org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.WriteLacCallback;
@@ -112,6 +114,8 @@ public void writeLacComplete(int rc, long ledgerId, BookieId addr, Object ctx) {
112114

113115
if (receivedResponseSet.isEmpty()){
114116
completed = true;
117+
ReferenceCountUtil.release(toSend);
118+
toSend = null;
115119
cb.addLacComplete(lastSeenError, lh, ctx);
116120
}
117121
}

0 commit comments

Comments
 (0)