[Bugfix] make metadataDriver initialization more robust (#3873)

ZanderXu · zengqiang.xu · web-flow · commit c3e5bfe431c1 · 2023-03-17T10:02:14.000+01:00
Co-authored-by: zengqiang.xu &lt;zengqiang.xu@shopee.com&gt;
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/EmbeddedServer.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/server/EmbeddedServer.java
@@ -302,7 +302,7 @@ public EmbeddedServer build() throws Exception {
 
             // 2. Build metadata driver
             if (metadataDriver == null) {
-                if (ledgerManagerFactory == null && registrationManager == null) {
+                if (ledgerManagerFactory == null || registrationManager == null) {
                     metadataDriver = BookieResources.createMetadataDriver(conf.getServerConf(), rootStatsLogger);
                     serverBuilder.addComponent(new AutoCloseableLifecycleComponent("metadataDriver", metadataDriver));
                 }

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ public EmbeddedServer build() throws Exception {`
`302`	`302`
`303`	`303`	`// 2. Build metadata driver`
`304`	`304`	`if (metadataDriver == null) {`
`305`		`- if (ledgerManagerFactory == null && registrationManager == null) {`
	`305`	`+ if (ledgerManagerFactory == null \|\| registrationManager == null) {`
`306`	`306`	`metadataDriver = BookieResources.createMetadataDriver(conf.getServerConf(), rootStatsLogger);`
`307`	`307`	`serverBuilder.addComponent(new AutoCloseableLifecycleComponent("metadataDriver", metadataDriver));`
`308`	`308`	`}`