Skip to content

Commit c9b893f

Browse files
authored
Remove commons-configuration2 and commons-beanutils from top level dependencies (#4648)
* Remove commons-configuration2 and commons-beanutils from dependencies of all modules * Add commons-logging to dependency management
1 parent 417ff16 commit c9b893f

File tree

5 files changed

+42
-9
lines changed

5 files changed

+42
-9
lines changed

bookkeeper-common/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,15 @@
3535
<artifactId>cpu-affinity</artifactId>
3636
<version>${project.parent.version}</version>
3737
</dependency>
38+
<dependency>
39+
<groupId>org.apache.commons</groupId>
40+
<artifactId>commons-configuration2</artifactId>
41+
</dependency>
42+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
43+
<dependency>
44+
<groupId>commons-beanutils</groupId>
45+
<artifactId>commons-beanutils</artifactId>
46+
</dependency>
3847
<dependency>
3948
<groupId>com.google.guava</groupId>
4049
<artifactId>guava</artifactId>

bookkeeper-http/http-server/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@
2828
<name>Apache BookKeeper :: Http :: Http Server</name>
2929
<url>http://maven.apache.org</url>
3030
<dependencies>
31+
<dependency>
32+
<groupId>org.apache.commons</groupId>
33+
<artifactId>commons-configuration2</artifactId>
34+
</dependency>
35+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
36+
<dependency>
37+
<groupId>commons-beanutils</groupId>
38+
<artifactId>commons-beanutils</artifactId>
39+
</dependency>
3140
<dependency>
3241
<groupId>com.fasterxml.jackson.core</groupId>
3342
<artifactId>jackson-core</artifactId>

pom.xml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@
128128
<commons-compress.version>1.27.1</commons-compress.version>
129129
<commons-lang.version>2.6</commons-lang.version>
130130
<commons-lang3.version>3.17.0</commons-lang3.version>
131+
<commons-logging.version>1.3.5</commons-logging.version>
131132
<commons-io.version>2.19.0</commons-io.version>
132133
<bouncycastle.version>1.0.2.5</bouncycastle.version>
133134
<curator.version>5.7.1</curator.version>
@@ -298,6 +299,11 @@
298299
<artifactId>commons-lang</artifactId>
299300
<version>${commons-lang.version}</version>
300301
</dependency>
302+
<dependency>
303+
<groupId>commons-logging</groupId>
304+
<artifactId>commons-logging</artifactId>
305+
<version>${commons-logging.version}</version>
306+
</dependency>
301307
<dependency>
302308
<groupId>com.google.guava</groupId>
303309
<artifactId>guava</artifactId>
@@ -871,15 +877,6 @@
871877
<groupId>org.slf4j</groupId>
872878
<artifactId>slf4j-api</artifactId>
873879
</dependency>
874-
<dependency>
875-
<groupId>org.apache.commons</groupId>
876-
<artifactId>commons-configuration2</artifactId>
877-
</dependency>
878-
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
879-
<dependency>
880-
<groupId>commons-beanutils</groupId>
881-
<artifactId>commons-beanutils</artifactId>
882-
</dependency>
883880
<!-- test dependencies -->
884881
<dependency>
885882
<groupId>junit</groupId>

stats/bookkeeper-stats-api/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,14 @@
5858
</plugins>
5959
</build>
6060
<dependencies>
61+
<dependency>
62+
<groupId>org.apache.commons</groupId>
63+
<artifactId>commons-configuration2</artifactId>
64+
</dependency>
65+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
66+
<dependency>
67+
<groupId>commons-beanutils</groupId>
68+
<artifactId>commons-beanutils</artifactId>
69+
</dependency>
6170
</dependencies>
6271
</project>

tests/shaded/distributedlog-core-shaded-test/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,15 @@
7979
<groupId>io.netty</groupId>
8080
<artifactId>netty-buffer</artifactId>
8181
</dependency>
82+
<dependency>
83+
<groupId>org.apache.commons</groupId>
84+
<artifactId>commons-configuration2</artifactId>
85+
</dependency>
86+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
87+
<dependency>
88+
<groupId>commons-beanutils</groupId>
89+
<artifactId>commons-beanutils</artifactId>
90+
</dependency>
8291
</dependencies>
8392
<build>
8493
<plugins>

0 commit comments

Comments
 (0)