Skip to content

Commit da18f92

Browse files
lhotarimerlimat
authored andcommitted
Remove commons-configuration2 and commons-beanutils from top level dependencies (#4648)
* Remove commons-configuration2 and commons-beanutils from dependencies of all modules * Add commons-logging to dependency management
1 parent 55308e9 commit da18f92

File tree

5 files changed

+42
-9
lines changed

5 files changed

+42
-9
lines changed

bookkeeper-common/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,15 @@
3535
<artifactId>cpu-affinity</artifactId>
3636
<version>${project.parent.version}</version>
3737
</dependency>
38+
<dependency>
39+
<groupId>org.apache.commons</groupId>
40+
<artifactId>commons-configuration2</artifactId>
41+
</dependency>
42+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
43+
<dependency>
44+
<groupId>commons-beanutils</groupId>
45+
<artifactId>commons-beanutils</artifactId>
46+
</dependency>
3847
<dependency>
3948
<groupId>com.google.guava</groupId>
4049
<artifactId>guava</artifactId>

bookkeeper-http/http-server/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@
2828
<name>Apache BookKeeper :: Http :: Http Server</name>
2929
<url>http://maven.apache.org</url>
3030
<dependencies>
31+
<dependency>
32+
<groupId>org.apache.commons</groupId>
33+
<artifactId>commons-configuration2</artifactId>
34+
</dependency>
35+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
36+
<dependency>
37+
<groupId>commons-beanutils</groupId>
38+
<artifactId>commons-beanutils</artifactId>
39+
</dependency>
3140
<dependency>
3241
<groupId>com.fasterxml.jackson.core</groupId>
3342
<artifactId>jackson-core</artifactId>

pom.xml

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@
126126
<commons-compress.version>1.27.1</commons-compress.version>
127127
<commons-lang.version>2.6</commons-lang.version>
128128
<commons-lang3.version>3.17.0</commons-lang3.version>
129+
<commons-logging.version>1.3.5</commons-logging.version>
129130
<commons-io.version>2.19.0</commons-io.version>
130131
<bouncycastle.version>1.0.2.4</bouncycastle.version>
131132
<curator.version>5.7.1</curator.version>
@@ -292,6 +293,11 @@
292293
<artifactId>commons-lang</artifactId>
293294
<version>${commons-lang.version}</version>
294295
</dependency>
296+
<dependency>
297+
<groupId>commons-logging</groupId>
298+
<artifactId>commons-logging</artifactId>
299+
<version>${commons-logging.version}</version>
300+
</dependency>
295301
<dependency>
296302
<groupId>com.google.guava</groupId>
297303
<artifactId>guava</artifactId>
@@ -865,15 +871,6 @@
865871
<groupId>org.slf4j</groupId>
866872
<artifactId>slf4j-api</artifactId>
867873
</dependency>
868-
<dependency>
869-
<groupId>org.apache.commons</groupId>
870-
<artifactId>commons-configuration2</artifactId>
871-
</dependency>
872-
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
873-
<dependency>
874-
<groupId>commons-beanutils</groupId>
875-
<artifactId>commons-beanutils</artifactId>
876-
</dependency>
877874
<!-- test dependencies -->
878875
<dependency>
879876
<groupId>junit</groupId>

stats/bookkeeper-stats-api/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,14 @@
5959
</plugins>
6060
</build>
6161
<dependencies>
62+
<dependency>
63+
<groupId>org.apache.commons</groupId>
64+
<artifactId>commons-configuration2</artifactId>
65+
</dependency>
66+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
67+
<dependency>
68+
<groupId>commons-beanutils</groupId>
69+
<artifactId>commons-beanutils</artifactId>
70+
</dependency>
6271
</dependencies>
6372
</project>

tests/shaded/distributedlog-core-shaded-test/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,15 @@
7575
<groupId>io.netty</groupId>
7676
<artifactId>netty-buffer</artifactId>
7777
</dependency>
78+
<dependency>
79+
<groupId>org.apache.commons</groupId>
80+
<artifactId>commons-configuration2</artifactId>
81+
</dependency>
82+
<!-- commons-configuration2 has an optional dependency on commons-beanutils -->
83+
<dependency>
84+
<groupId>commons-beanutils</groupId>
85+
<artifactId>commons-beanutils</artifactId>
86+
</dependency>
7887
</dependencies>
7988
<build>
8089
<plugins>

0 commit comments

Comments
 (0)