Skip to content

Allocator support exitOnOutOfMemory config. #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StevenLuMT merged 11 commits into from
Jul 15, 2024
Merged

Allocator support exitOnOutOfMemory config. #3984

StevenLuMT merged 11 commits into from
Jul 15, 2024

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Jun 12, 2023 •
edited
Loading

Descriptions of the changes in this PR:
In some cases, if the process can't allocate memory, we would better exit the JVM, or the bookie can't serve, and the client always timeout.
Add config allocatorExitOnOutOfMemory. When the allocator encounters oom, exit the JVM.

@hangc0276
Copy link
Contributor

hangc0276 commented Jun 13, 2023

@horizonzy Please fix the check style, thanks.

hangc0276
hangc0276 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@hangc0276
Copy link
Contributor

hangc0276 commented Jun 13, 2023

@lhotari Please help take a look, thanks.

@horizonzy
Copy link
Member Author

horizonzy commented Jun 13, 2023 •
edited
Loading

The ci failed. Fixing it now.

@horizonzy
Copy link
Member Author

horizonzy commented Jun 13, 2023

The ci failed. Fixing it now.

done

dlg99
dlg99 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@horizonzy
Copy link
Member Author

horizonzy commented Jun 29, 2023

rerun failure checks

hezhangjian
hezhangjian requested changes May 5, 2024
View reviewed changes
Copy link
Member

@hezhangjian hezhangjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please rebase this code? we have deprecated powermock usage now.

StevenLuMT
StevenLuMT approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@StevenLuMT StevenLuMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bookkeeper-common-allocator/src/main/java/org/apache/bookkeeper/common/util/ShutdownUtil.java
*/
@Slf4j
public class ShutdownUtil {
private static final Method log4j2ShutdownMethod;
Copy link
Member

@StevenLuMT StevenLuMT Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, this is copied from pulsar-common directly, why not import pulsar-common in bookkeeper/bookkeeper-common-allocator/pom.xml

Copy link
Member

@StevenLuMT StevenLuMT Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the ShutdownUtil problem, the rest are pretty good,LGTM @horizonzy

Copy link
Member Author

@horizonzy horizonzy Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor import, we needn't import new dependency.

@StevenLuMT
Copy link
Member

StevenLuMT commented Jul 15, 2024

image please fix the checkstyle issue, thanks @horizonzy

@StevenLuMT StevenLuMT merged commit 15b106c into apache:master Jul 15, 2024
lhotari pushed a commit that referenced this pull request Apr 16, 2025
@horizonzy @lhotari
Allocator support exitOnOutOfMemory config. (#3984)
7b31933 
* Allocator support exitOnOutOfMemory config.

(cherry picked from commit 15b106c)
lhotari pushed a commit that referenced this pull request Apr 16, 2025
@horizonzy @lhotari
Allocator support exitOnOutOfMemory config. (#3984)
a05bc53 
* Allocator support exitOnOutOfMemory config.

(cherry picked from commit 15b106c)
priyanshu-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 11, 2025
@horizonzy @priyanshu-ctds
Allocator support exitOnOutOfMemory config. (apache#3984)
2995d8c 
* Allocator support exitOnOutOfMemory config.

(cherry picked from commit 15b106c)
(cherry picked from commit 7b31933)
sandeep-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 22, 2025
@horizonzy @sandeep-ctds
Allocator support exitOnOutOfMemory config. (apache#3984)
4ee8f28 
* Allocator support exitOnOutOfMemory config.

(cherry picked from commit 15b106c)
(cherry picked from commit 7b31933)
@hangc0276
Copy link
Contributor

hangc0276 commented Jul 23, 2025

@StevenLuMT This PR changed the interface, and we should not cherry-pick it to the patch branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hangc0276 hangc0276 hangc0276 approved these changes

@dlg99 dlg99 dlg99 approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

@StevenLuMT StevenLuMT StevenLuMT approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@Vanlightly Vanlightly Awaiting requested review from Vanlightly

@eolivelli eolivelli Awaiting requested review from eolivelli

@zymap zymap Awaiting requested review from zymap

Assignees

@horizonzy horizonzy

Labels

cherry-picked/branch-4.16 cherry-picked/branch-4.17 release/4.16.7 release/4.17.2 type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@horizonzy @hangc0276 @StevenLuMT @dlg99 @hezhangjian @lhotari